Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟 Remove link to Pydantic's benchmark, as it was removed there #5811

Merged
merged 3 commits into from Jun 10, 2023

Conversation

Kludex
Copy link
Sponsor Collaborator

@Kludex Kludex commented Dec 27, 2022

The link was removed.

Maybe there's a replacement with Pydantic V2? 馃し

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit dbdd570 at: https://63aaf329dbd3c70f4d16c9f9--fastapi.netlify.app

Copy link

@Ryandaydev Ryandaydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broken link removal is good. @Kludex it appears that the section describing the benefits of Pydantic (lines 185-198) were from an old version of the pydantic home page. I think you could create another PR to update the rest of the bullets.

@tiangolo tiangolo changed the title Remove link to Pydantic's benchmark 馃敟 Remove link to Pydantic's benchmark, as it was removed there Jun 10, 2023
@tiangolo
Copy link
Owner

Yep, makes sense, thanks @Kludex! 馃殌 馃敟

@tiangolo tiangolo enabled auto-merge (squash) June 10, 2023 12:09
@tiangolo
Copy link
Owner

馃摑 Docs preview for commit cf04532 at: https://6484acdd2c003b7bcebeaad8--fastapi.netlify.app

auto-merge was automatically disabled June 10, 2023 17:04

Base branch was modified

@tiangolo tiangolo merged commit 19757d1 into tiangolo:master Jun 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants