-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摑 Update Deta deployment tutorial for compatibility with Deta Space #6004
Conversation
馃摑 Docs preview for commit 0b1015d at: https://63ed3437f56a5a0b8b5107a3--fastapi.netlify.app |
WIP / draft |
Are there any tests associated with this PR? |
|
docs/en/docs/deployment/deta.md
Outdated
return {"Hello": "World"} | ||
|
||
|
||
@app.get("/items/{item_id}") | ||
def read_item(item_id: int): | ||
print({"item_id": item_id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print({"item_id": item_id}) | |
print({"item_id": item_id}) |
Update deta.md
馃摑 Docs preview for commit 1338fc5 at: https://63f78a8c1643cf265e41d8e8--fastapi.netlify.app |
docs/en/docs/deployment/deta.md
Outdated
|
||
|
||
@app.get("/items/{item_id}") | ||
def read_item(item_id: int): | ||
async def read_item(item_id: int): | ||
print({"item_id": item_id}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would remove
馃摑 Docs preview for commit c6052d1 at: https://63fe05f5e66d1b1476d2cae2--fastapi.netlify.app |
馃摑 Docs preview for commit aaa48cf at: https://63fe1fd1421e2c0d783763a7--fastapi.netlify.app |
馃摑 Docs preview for commit 904b621 at: https://63fe41853295e9147523ff47--fastapi.netlify.app |
馃摑 Docs preview for commit 6cafe99 at: https://63fe739d3295e93fb3240118--fastapi.netlify.app |
discord link
馃摑 Docs preview for commit fdb61b9 at: https://63fefcb7d08d5446ade7f581--fastapi.netlify.app |
馃摑 Docs preview for commit 0d65d03 at: https://641aea09031a44054a70c337--fastapi.netlify.app |
馃摑 Docs preview for commit 1287683 at: https://643955486ac93f00770378d2--fastapi.netlify.app |
馃摑 Docs preview for commit 6bd7fe2 at: https://6458e3861db33321daa14ef6--fastapi.netlify.app |
馃摑 Docs preview for commit 4216a16 at: https://6458ea680554c8318143eb7d--fastapi.netlify.app |
Thanks @mikBighne98! 馃嵃 I tweaked the docs a bit, fixed a couple of things, updated a couple others for consistency, renamed the images to keep the old ones for the translations, and fixed the console outputs, this is ready! 馃殌 |
Thank you for reviewing and merging the PR, @tiangolo 馃檪 |
No description provided.