Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging #781

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Refactor logging #781

merged 2 commits into from
Dec 9, 2019

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Dec 9, 2019

🔊 Refactor logging.

  • Use the same logger everywhere to make sure the custom fastapi logger is used.
  • Update logging strings to fix format.
  • Update log level of email-validator errors to INFO, not WARNING.

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #781 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #781   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         276    277    +1     
  Lines        7208   7210    +2     
=====================================
+ Hits         7208   7210    +2
Impacted Files Coverage Δ
fastapi/logger.py 100% <100%> (ø)
fastapi/openapi/models.py 100% <100%> (ø) ⬆️
fastapi/routing.py 100% <100%> (ø) ⬆️
fastapi/encoders.py 100% <100%> (ø) ⬆️
fastapi/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc78c5...53916e2. Read the comment docs.

@tiangolo tiangolo merged commit 83d04df into master Dec 9, 2019
@tiangolo tiangolo deleted the refactor-logging branch December 9, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant