Fix body parsing #918
Merged
Fix body parsing #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Jan 25, 2020
| @@ -685,6 +678,16 @@ def request_params_to_args( | |||
| return values, errors | |||
|
|
|||
|
|
|||
| def get_missing_field_error(field_alias: str) -> ErrorWrapper: | |||
There was a problem hiding this comment.
Since this error is now used in two places, I added a utility function to generate it.
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 293 293
Lines 7692 7699 +7
=====================================
+ Hits 7692 7699 +7
Continue to review full report at Codecov.
|
|
Awesome, thanks @dmontagu ! 🚀 🍰 And thanks for the clear explanation 🤓 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #914
I believe this is the "correct" way to fix this issue, as the provided body could be invalid in a number of ways, and this should handle anything that json could get parsed into. (The error message also seems appropriate to me even for malformed bodies.)
There was actually already a test for this, but it only checked for a (malformed) body of
None, not[], so it was easy to add a test case as another parametric case.