Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Portuguese translation for docs/pt/docs/advanced/events.md #9326

Merged
merged 9 commits into from May 8, 2023
Merged

🌐 Add Portuguese translation for docs/pt/docs/advanced/events.md #9326

merged 9 commits into from May 8, 2023

Conversation

oandersonmagalhaes
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

📝 Docs preview for commit fcd966f at: https://6423813dd08506199aa8e03f--fastapi.netlify.app

@Kludex Kludex added lang-all Translations lang-pt Portuguese translations awaiting-review labels Mar 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

📝 Docs preview for commit 6968bfe at: https://642b3e1536db80082ae410bc--fastapi.netlify.app

fcrozetta
fcrozetta suggested changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@fcrozetta fcrozetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

  • One small grammar change (My spell check keeps pointing the accent should not be there 🤷🏻‍♂️)
  • the phrase in parenthesis was not translated to BR🇧🇷

docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
@oandersonmagalhaes @fcrozetta
Update docs/pt/docs/advanced/events.md
43aff4f 
Co-authored-by: Fernando Crozetta <fernando@czetta.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

📝 Docs preview for commit 43aff4f at: https://6431d4d42e231e767ec8c459--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 5a8102d at: https://644667e10c8fa210b18c2ed5--fastapi.netlify.app

@oandersonmagalhaes
Copy link
Contributor Author

@LorhanSohaky and @fabioueno, could you take a look at this PR, please? 😅

@github-actions
Copy link
Contributor

📝 Docs preview for commit 26e928c at: https://64487e6f116d705f2e58be4e--fastapi.netlify.app

@LorhanSohaky
Copy link
Contributor

@LorhanSohaky and @fabioueno, could you take a look at this PR, please? 😅

At the end of the day I will review

LorhanSohaky
LorhanSohaky suggested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@LorhanSohaky LorhanSohaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some typos, standardized some terms used throughout the text and
I think that with these suggestions the reading becomes more fluid

docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
docs/pt/docs/advanced/events.md Outdated Show resolved Hide resolved
@oandersonmagalhaes @LorhanSohaky
Apply suggestions from code review
5a5d05a 
Co-authored-by: Lorhan Sohaky <16273730+LorhanSohaky@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 5a5d05a at: https://644abbf094090e07d7d72287--fastapi.netlify.app

LorhanSohaky
LorhanSohaky approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@LorhanSohaky LorhanSohaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📝 Docs preview for commit c4c8480 at: https://6451712516dd18096c35e217--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented May 8, 2023

Awesome, thanks @oandersonmagalhaes! 🚀

And thanks for the reviews @LorhanSohaky and @fcrozetta 🙇

@tiangolo tiangolo merged commit f2d01d7 into tiangolo:master May 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcrozetta fcrozetta fcrozetta approved these changes

@LorhanSohaky LorhanSohaky LorhanSohaky approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oandersonmagalhaes @LorhanSohaky @tiangolo @fcrozetta @Kludex