Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add setup for translations to Lao #9396

Merged
merged 24 commits into from
May 8, 2023
Merged

🌐 Add setup for translations to Lao #9396

merged 24 commits into from
May 8, 2023

Conversation

TheBrown
Copy link
Contributor

About Laos: Laos is a landlocked country in South-east Asia on the Indochinese peninsula between Thailand and Vietnam and north of Cambodia.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 2061336 at: https://643a13863ca51b392fdc1ae1--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 5c8abe8 at: https://643aa8823f8df430232a6eae--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit f3e00d5 at: https://643ab594d5f25b3e7e2ff577--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6efdf81 at: https://643b66053f8df4555e2a6f10--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4edc281 at: https://643bcd9ad5f25b29d42ff5bd--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 2ee0a38 at: https://643d496c4935860d4c301ca3--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit ed44080 at: https://643e1f8f3546976a6042375c--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8867a74 at: https://643e2638fd1db96f4388bc79--fastapi.netlify.app

@TheBrown TheBrown closed this Apr 19, 2023
@TheBrown TheBrown reopened this Apr 19, 2023
@github-actions
Copy link
Contributor

📝 Docs preview for commit fc8bb3f at: https://643f662f85825e3e6e6f469b--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 12eac6e at: https://6440cd6e1eb66c3eeeede2e8--fastapi.netlify.app

@tiangolo tiangolo changed the title Add a new language, Lao. 🌐 Add setup for translations to Lao Apr 25, 2023
tiangolo
tiangolo requested changes Apr 25, 2023
View reviewed changes
Copy link
Owner

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm asking you to remove a few files for translations, those should go in independent PRs, that way others can review and approve or ask for changes one by one.

docs/lo/docs/alternatives.md Outdated Show resolved Hide resolved
docs/lo/docs/benchmarks.md Outdated Show resolved Hide resolved
docs/lo/docs/contributing.md Outdated Show resolved Hide resolved
docs/lo/docs/deployment/index.md Outdated Show resolved Hide resolved
docs/lo/docs/fastapi-people.md Outdated Show resolved Hide resolved
docs/lo/docs/project-generation.md Outdated Show resolved Hide resolved
docs/lo/docs/python-types.md Outdated Show resolved Hide resolved
docs/lo/docs/tutorial/index.md Outdated Show resolved Hide resolved
docs/lo/docs/tutorial/security/oauth2-jwt.md Outdated Show resolved Hide resolved
docs/lo/release-notes.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

📝 Docs preview for commit a54064b at: https://64489595fbfcff786d4a37a4--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit c4d7c03 at: https://64489910f5de067a6faff223--fastapi.netlify.app

@TheBrown
Copy link
Contributor Author

TheBrown commented Apr 26, 2023 •
edited
Loading

Hi @tiangolo Thank you for your suggestion. I have resolved all changes requested.

@github-actions
Copy link
Contributor

📝 Docs preview for commit d41ea1c at: https://6448bc845f60f10d2a256b17--fastapi.netlify.app

@TheBrown
Copy link
Contributor Author

Is the current file update ok? @tiangolo

@tiangolo tiangolo added lang-all Translations lang-lo Lao translations labels May 4, 2023
@tiangolo
Copy link
Owner

tiangolo commented May 8, 2023

Great, thank you @TheBrown! 🚀

@tiangolo tiangolo merged commit ed1f93f into tiangolo:master May 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo requested changes

Assignees
No one assigned
Labels
lang-all Translations lang-lo Lao translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheBrown @tiangolo