Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add German translation for docs/de/docs/tutorial/first-steps.md #9530

Merged
merged 21 commits into from Jan 9, 2024
Merged

🌐 Add German translation for docs/de/docs/tutorial/first-steps.md #9530

merged 21 commits into from Jan 9, 2024

Conversation

fhabers21
Copy link
Contributor

add german translation for tutorial/first-steps.md

@github-actions
Copy link
Contributor

📝 Docs preview for commit 231bd13 at: https://645f64fef610242c1ea1d455--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add german translation for docs/de/docs/tutorial/first-steps.md 🌐 Add German translation for docs/de/docs/tutorial/first-steps.md Jun 3, 2023
@tiangolo tiangolo added lang-all Translations awaiting-review lang-de German translations labels Jun 3, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 4eb2246 at: https://649a2ec1c3bf902028a9e518--fastapi.netlify.app

creyD
creyD suggested changes Aug 31, 2023
View reviewed changes
Copy link

@creyD creyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comments I had, I liked the translation.

docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
@creyD
Copy link

creyD commented Aug 31, 2023

@tiangolo Would it be possible to adjust the docs so that the reader already knows that the article will be in another language than the selected one? Here i.e. there is no translated version yet for the section, so the reader will automatically be redirected to the English one, which is fine, just would be nice to have indication beforehand.
Screenshot 2023-08-31 at 16 19 40

@fhabers21
Copy link
Contributor Author

@creyD Thank you for your valuable feedback. I corrected the points you mentioned.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 1955f38 at: https://e6f4a35f.fastapitiangolo.pages.dev

creyD
creyD approved these changes Sep 1, 2023
View reviewed changes
Copy link

@creyD creyD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments, I believe it is good to go now!

@tiangolo
Copy link
Owner

tiangolo commented Sep 2, 2023

📝 Docs preview for commit 4dca8ea at: https://c7d03784.fastapitiangolo.pages.dev

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
@nilslindemann
German translation of docs/tutorial/first-steps.md
7c1411f 
* Full translation
* Based on tiangolo#9530
* In sync with current en/docs/tutorial/first-steps.md
* Hand-translated (Google translate rarely used)
* Checked for errors using LanguageTool
* Manually checked
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
@nilslindemann
Create de/docs/tutorial/first-steps.md
d99a066 
Based on tiangolo#4520 and tiangolo#9530
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Sep 20, 2023
@nilslindemann
Create de/docs/tutorial/index.md
5a66fff 
Based on tiangolo#4517 and tiangolo#9530
This was referenced Sep 21, 2023
Closed
Closed
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Oct 5, 2023
@nilslindemann
Come closer to tiangolo#9530
6d8de00
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Oct 5, 2023
@nilslindemann
Come closer to tiangolo#9530
dd9d7c9
@nilslindemann
Copy link
Contributor

Hello @fhabers21, good PR, I approved it.

Could you include the suggestions in the following .md?

first-steps.md

These are mostly changes suggested by GeorchW, who approved my other closed PR. Then he could approve this PR here too (ping, @GeorchW), and we can get this merged. 🚀

nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
@nilslindemann
tut/first-steps.md (tiangolo#9530 tiangolo#10289)
51576c2
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
@nilslindemann
tut/first-steps.md (tiangolo#9530 tiangolo#10289)
e97ac2e
@nilslindemann nilslindemann mentioned this pull request Nov 3, 2023
Merged
fhabers21 and others added 13 commits November 11, 2023 13:52
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
575779a 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
443fa6d 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
de92e24 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
1686f5f 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
50745d1 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
2919d55 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
51cdf1c 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
9f59c8e 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
ca9aa58 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
faf687a 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21 @GeorchW
Update docs/de/docs/tutorial/first-steps.md
669fc4d 
Co-authored-by: Georg Wicke-Arndt <g.wicke-arndt@outlook.com>
@fhabers21
Merge branch 'master' into language/tutorial-first-steps-de
2f28a20
@fhabers21
include feedback from nilslindemann
9713bcf
@fhabers21
Copy link
Contributor Author

@nilslindemann, @GeorchW, big thanks for your valuable feedback. I've included your suggestions.

@tiangolo, we might be good to go.

@tiangolo
Copy link
Owner

📝 Docs preview for commit 9713bcf at: https://04391ef4.fastapitiangolo.pages.dev

nilslindemann
nilslindemann approved these changes Nov 11, 2023
View reviewed changes
docs/de/docs/tutorial/first-steps.md Outdated Show resolved Hide resolved
@nilslindemann
Copy link
Contributor

Superklasse! Kann meines Erachtens gemerged werden. Nur noch die eine Stelle, wo die „typografischen“ fehlen.

@fhabers21
Copy link
Contributor Author

fhabers21 commented Nov 12, 2023 •
edited

@nilslindemann danke für deinen erneuten Review! Habe die Stelle ausgebessert.

@tiangolo
Copy link
Owner

📝 Docs preview for commit addad7f at: https://d654ffb8.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor

Ich hab noch eine Kleinigkeit entdeckt: In Zeile 46 könnte man JSON-Response statt JSON-Antwort schreiben. Ist aber "Geschmäckle" :-)

@tiangolo
Copy link
Owner

tiangolo commented Jan 9, 2024

Nice, thank you @fhabers21! 🚀

And thanks for the reviews @nilslindemann, @GeorchW, @creyD 🙇

@tiangolo tiangolo merged commit 031000f into tiangolo:master Jan 9, 2024
37 checks passed
@fhabers21 fhabers21 deleted the language/tutorial-first-steps-de branch January 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslindemann nilslindemann nilslindemann approved these changes

@GeorchW GeorchW GeorchW approved these changes

@creyD creyD creyD approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-de German translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fhabers21 @tiangolo @creyD @nilslindemann @GeorchW