Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Russian translation for docs/ru/docs/tutorial/path-params-numeric-validations.md #9563

Merged
merged 3 commits into from
Jun 3, 2023
Merged

🌐 Add Russian translation for docs/ru/docs/tutorial/path-params-numeric-validations.md #9563

merged 3 commits into from
Jun 3, 2023

Conversation

ivan-abc
Copy link
Contributor

No description provided.

@ivan-abc ivan-abc changed the title added russian translation for tutorial/path-params-numeric-validations Add Russian translation for docs/ru/docs/tutorial/tutorial/path-params-numeric-validations.md May 23, 2023
@ivan-abc ivan-abc changed the title Add Russian translation for docs/ru/docs/tutorial/tutorial/path-params-numeric-validations.md 🌐 Add Russian translation for docs/ru/docs/tutorial/tutorial/path-params-numeric-validations.md May 23, 2023
@github-actions
Copy link
Contributor

📝 Docs preview for commit ca1ac13 at: https://646d1b67af47f2403b3d1292--fastapi.netlify.app

@ivan-abc ivan-abc changed the title 🌐 Add Russian translation for docs/ru/docs/tutorial/tutorial/path-params-numeric-validations.md 🌐 Add Russian translation for docs/ru/docs/tutorial/path-params-numeric-validations.md May 23, 2023
@Kludex Kludex added lang-all Translations lang-ru Russian translations awaiting-review labels May 24, 2023
@Xewus
Copy link
Contributor

Xewus commented May 24, 2023

The original page was updated on April 13. Your translate is dated May 23.
Why doesn't it match the original?

@ivan-abc
Copy link
Contributor Author

The original page was updated on April 13. Your translate is dated May 23. Why doesn't it match the original?

Missed this 🤦‍♂️

@github-actions
Copy link
Contributor

📝 Docs preview for commit 2956d7b at: https://646e8177adf0ce29d7b18397--fastapi.netlify.app

@ivan-abc @Xewus
Apply suggestions from code review
4e1d801 
Co-authored-by: Vladislav Kramorenko <85196001+Xewus@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 4e1d801 at: https://646f937ba4ddff2316ee4dd4--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Russian translation for docs/ru/docs/tutorial/path-params-numeric-validations.md 🌐 Add Russian translation for docs/ru/docs/tutorial/path-params-numeric-validations.md Jun 3, 2023
@tiangolo
Copy link
Owner

tiangolo commented Jun 3, 2023

Thanks @ivan-abc! 🍰

And thanks for the reviews @starlingnic, @Xewus, @Alexandrhub 👏 ☕

@tiangolo tiangolo merged commit ad77d7f into tiangolo:master Jun 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starlingnic starlingnic starlingnic approved these changes

@Xewus Xewus Xewus approved these changes

@Alexandrhub Alexandrhub Alexandrhub approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ru Russian translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ivan-abc @Xewus @tiangolo @starlingnic @Alexandrhub @Kludex