Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Update SQLAlchemy instruction in Chinese translation docs/zh/docs/tutorial/sql-databases.md #9712

Merged
merged 10 commits into from Jan 9, 2024
Merged

🌐 Update SQLAlchemy instruction in Chinese translation docs/zh/docs/tutorial/sql-databases.md #9712

merged 10 commits into from Jan 9, 2024

Conversation

Royc30ne
Copy link
Contributor

  • 📝 Update SQLAlchemy install command (keep the same version with English tutorial)

  • 📝 Add more database connection examples (Microsoft SQL Server, MySQL, Oracle)

@Royc30ne
📝 Update SQLAlchemy related instruction
fa739ce 
* 📝 Update SQLAlchemy install command (keep the same version with English tutorial)

* 📝 Add more database connection examples (Microsoft SQL Server, MySQL, Oracle)
@tiangolo
Copy link
Owner

📝 Docs preview for commit fa739ce at: https://6493434b7d4eb10097a081b2--fastapi.netlify.app

@tiangolo tiangolo changed the title 📝 Update SQLAlchemy related instruction in Chinese 🌐 Update SQLAlchemy instruction in Chinese translation docs/zh/docs/tutorial/sql-databases.md Jun 22, 2023
@tiangolo
Copy link
Owner

Thanks for your interest! ☕

Nevertheless, the translation shouldn't add more information that is not in the original English version. Please remove the extra info. 🤓

@tiangolo tiangolo added lang-all Translations lang-zh Chinese translations labels Jun 22, 2023
tiangolo
tiangolo requested changes Jun 22, 2023
View reviewed changes
docs/zh/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
@Royc30ne
Copy link
Contributor Author

The branch has been updated according to the given requirement.

@tiangolo
Copy link
Owner

📝 Docs preview for commit f0555b9 at: https://64962486c3187f0080efecdd--fastapi.netlify.app

@Royc30ne Royc30ne requested a review from tiangolo June 25, 2023 15:30
@tiangolo
Copy link
Owner

📝 Docs preview for commit b201a82 at: https://649a31ab05f6af2160d6ced9--fastapi.netlify.app

mkdir700
mkdir700 suggested changes Jun 27, 2023
View reviewed changes
docs/zh/docs/tutorial/sql-databases.md Outdated Show resolved Hide resolved
@Royc30ne
Update sql-databases.md
9d91eb2 
Update the style for code space
@tiangolo
Copy link
Owner

tiangolo commented Jul 1, 2023

📝 Docs preview for commit 9d91eb2 at: https://64a050461a33a64781b26b2e--fastapi.netlify.app

@tiangolo
Copy link
Owner

tiangolo commented Jul 1, 2023

📝 Docs preview for commit 3ce1c81 at: https://64a0513257067b464793f3b7--fastapi.netlify.app

wdh99

This comment was marked as off-topic.

Sign in to view

@tiangolo
Copy link
Owner

tiangolo commented Jan 9, 2024

Great, thank you @Royc30ne! 🚀 🍰

And thanks for the reviews @Aruelius, @mkdir700, @HiemalBeryl, @wdh99 🙇 🍪

@tiangolo
Copy link
Owner

tiangolo commented Jan 9, 2024

📝 Docs preview for commit a35b2b9 at: https://0bee8146.fastapitiangolo.pages.dev

@tiangolo tiangolo merged commit 0f4b629 into tiangolo:master Jan 9, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aruelius Aruelius Aruelius approved these changes

@mkdir700 mkdir700 mkdir700 approved these changes

@HiemalBeryl HiemalBeryl HiemalBeryl approved these changes

@wdh99 wdh99 wdh99 approved these changes

@tiangolo tiangolo Awaiting requested review from tiangolo

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-zh Chinese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Royc30ne @tiangolo @Aruelius @mkdir700 @HiemalBeryl @wdh99