✨ Allow using dependables with functools.partial()
#9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiangolo
changed the title
functools.partial()
lieryan
force-pushed
the
lieryan-dependencies-with-functools-partial
branch
from
9562162
to
05ab699
Compare
9 tasks
|
This would be nice to have |
|
Yeah - I also just hit this! Please merge 😅 |
|
@tiangolo Are we any closer to a merge on this? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #9744
Using
functools.partial()with dependables feels like a very obvious idiom.partial()already works for dependables that are plain function, but it doesn't work consistently, partial of async and callable classes didn't work consistently.This PR makes partial() work consistently in all combinations.
test_dependency_class.py have been renamed to test_dependency_types.py to reflect its bigger scope now.
There's quite a bit of repetition in the tests, part of me wants to just refactor those; but another part of me also wants to keep the tests simple.