Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiecutter Windows Bug in worker-start.sh: CRLF Linebreaks #13

Closed
Sieboldianus opened this issue Apr 17, 2019 · 2 comments
Closed

Cookiecutter Windows Bug in worker-start.sh: CRLF Linebreaks #13

Sieboldianus opened this issue Apr 17, 2019 · 2 comments

Comments

@Sieboldianus
Copy link

Sieboldianus commented Apr 17, 2019

First, many thanks for this project! I am lookin forward to testing it.

I had some problems getting it to run on Windows and found the source (it was me). Even though it was my fault, I thought a note in the readme could be added for other users:

The backend would not start because linebreaks in worker-start.sh (and other bash-files) were CRLF (Windows), and not LF (Linux). In docker-compose logs this would appear as invalid command \r etc.

I used cookiecutter in Windows with cookiecutter https://github.com/tiangolo/full-stack-fastapi-postgresql, which issued CRLF linebreaks. Once using cookiecutter from WSL bash in Ubuntu, everything worked fine!

I think it generally a good recommendation to use docker-compose, and docker from WSL bash (connected through Windows Docker daemon running on localhost); and set VSCode (if used from Windows), to use LF in global settings with "files.eol": "\n".

@tiangolo
Copy link
Member

Thanks! I think it's a problem in Cookiecutter itself, this PR seems to fix it: cookiecutter/cookiecutter#1159

@tiangolo
Copy link
Member

This should be fixed by #149 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants