🗃️ Add max_length validation for database models and input data #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanx64
changed the title
tiangolo
reviewed
Jun 18, 2024
|
|
||
|
|
||
| # Properties to receive via API on creation | ||
| class UserCreate(UserBase): | ||
| password: str | ||
| password: str = Field(min_length=8, max_length=40) |
There was a problem hiding this comment.
Could you please update the max length of passwords to the same of the other text fields, with 255?
There was a problem hiding this comment.
I think it should be the max lenght?
There was a problem hiding this comment.
Yep, right @PhilippWu ! (just edited it)
There was a problem hiding this comment.
Chatting internally, @estebanx64 convinced me to leave this with 40. 😅
There was a problem hiding this comment.
Hi @tiangolo or @estebanx64 , would you be able to share the logic on the 40? Sounds counterintuitive to me, so something to learn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.