Skip to content

Commit

Permalink
✨ Raise an exception when using a Pydantic field type with no matchin…
Browse files Browse the repository at this point in the history
…g SQLAlchemy type (#18)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
  • Loading branch information
elben10 and tiangolo committed Aug 27, 2022
1 parent db29f53 commit dc4dc42
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
1 change: 1 addition & 0 deletions sqlmodel/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ def get_sqlachemy_type(field: ModelField) -> Any:
return AutoString
if issubclass(field.type_, uuid.UUID):
return GUID
raise ValueError(f"The field {field.name} has no matching SQLAlchemy type")


def get_column_from_field(field: ModelField) -> Column: # type: ignore
Expand Down
21 changes: 21 additions & 0 deletions tests/test_missing_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from typing import Optional

import pytest
from sqlmodel import Field, SQLModel


def test_missing_sql_type():
class CustomType:
@classmethod
def __get_validators__(cls):
yield cls.validate

@classmethod
def validate(cls, v):
return v

with pytest.raises(ValueError):

class Item(SQLModel, table=True):
id: Optional[int] = Field(default=None, primary_key=True)
item: CustomType

0 comments on commit dc4dc42

Please sign in to comment.