🐛 Fix fields marked as "set" in models #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request addresses the problem brought up in issue #87
By using the setattr to set even the default values of the SQLModel they all get added to the
pydantic.BaseModel.__fields_set__
attribute regardless if the user sets them. Simply, moving the setattr for the__fields_set__
to after this iteration correctly recreates the intended behavior from pydantic. I've included the small test below that passes on my machine along with the other unit tests.