Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update expresion.py, sync from Jinja2 template, implement inherit_cache to solve errors like: SAWarning: Class SelectOfScalar will not make use of SQL compilation caching #422

Merged
merged 3 commits into from Aug 29, 2022

Conversation

tiangolo
Copy link
Owner

♻️ Update expresion.py, sync from Jinja2 template.

Also add a test to ensure that the expression.py file is in sync with the Jinja2 template.

@tiangolo tiangolo changed the title ♻️ Update expresion.py, sync from Jinja2 template ♻️ Update expresion.py, sync from Jinja2 template, implement inherit_cache to solve errors like: SAWarning: Class SelectOfScalar will not make use of SQL compilation caching Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #422 (26377a2) into main (f232166) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   97.72%   97.58%   -0.15%     
==========================================
  Files         186      186              
  Lines        6201     6201              
==========================================
- Hits         6060     6051       -9     
- Misses        141      150       +9     
Impacted Files Coverage Δ
sqlmodel/sql/expression.py 74.35% <50.00%> (-23.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

📝 Docs preview for commit 08b8ac8 at: https://630c88e91b8fa505cf654ebf--sqlmodel.netlify.app

@github-actions
Copy link

📝 Docs preview for commit 26377a2 at: https://630c898d8dc0eb11126d5e9b--sqlmodel.netlify.app

@tiangolo tiangolo merged commit b51ebaf into main Aug 29, 2022
@tiangolo tiangolo deleted the update-expression-inherit-cache branch August 29, 2022 09:44
@tiangolo tiangolo mentioned this pull request Aug 29, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant