🐛 Fix default value of None for CLI Parameters when the type is list | None and the default value is None
#664
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theowisear
changed the title
svlandeg
reviewed
Feb 29, 2024
|
📝 Docs preview for commit 8d6aaf0 at: https://044fd36b.typertiangolo.pages.dev |
svlandeg
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
I've added an example in the docs and a unit test, and confirmed that this PR indeed changes the type of the argument to None as you would expect.
The fix itself looks good to me, but I'll leave this one up for review by @tiangolo to get his opinion as well.
|
📝 Docs preview for commit beaf3f1 at: https://331f9f9c.typertiangolo.pages.dev |
tiangolo
changed the title
None for CLI Parameters when the type is list | None and the default value is None
|
Great, thank you @theowisear! 🍪 And thanks for the help here @svlandeg! 🙇 🍰 This will be available in Typer 0.10.0, in the next few hours/minutes. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an optional list type option has default_value set to None, we expect its value to also be set to None if no option has been given to the command.
Related to issue #410