Make listen port configurable #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmshn
commented
Oct 19, 2017
README.md
Outdated
| ## What's new | ||
|
|
||
| * 2017-10-XX: Now you can configure which port the container should listen on, using the environment variable `LISTEN_PORT`. |
There was a problem hiding this comment.
Modify the date when you push the image, plz 🙏
|
Oh, and there're Alpine versions coming...I should have waited for them. |
|
Thanks! I'll review soon. 🎉 |
|
Thank you for your work @tmshn ! And thanks for clearly explaining the reason and linking the documentation that supports it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in README, I made listen port configurable.
Default port is still 80, so it's backward compatible ;)
This is useful when used with Google App Engine, which require containers to listen on 8080.
https://cloud.google.com/appengine/docs/flexible/custom-runtimes/build#listen_to_port_8080
I'm planning to send a pr to https://github.com/tiangolo/uwsgi-nginx-flask-docker too.