-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added adaway.root template #1337
Conversation
Why needs |
The |
Without this perm, the app can't seem to detect that it has root, on a fresh install/data cleared. I'm pinging @symbuzzer here who contributed to both KernelSU and Adaway for their input. Also pinging an Adaway maintainer @PerfectSlayer |
It shouldn't need CAP_SYS_PTRACE I think. I also don't understand why it needs to read process |
Can you find out why it needs to use the perm from the open source code? Adaway maintainer @PerfectSlayer seems to have stalled the project for a year. He is still active on GitHub though. |
I have no motivation for this, sorry ,:( |
Hey AdAway maintainer here 👋 Not sure either why It might also help if you are able to provide a logcat when it’s failing. |
Here's the log snippet. |
@PerfectSlayer |
Adaway only needs the following permissions to work properly: DAC_OVERRIDE, SYS_PTRACE Also added Bengali translation
Although there are still some doubts, I will merge it; because it is better to have restrictions than no restrictions at all. If you find out why PTRACE is needed, you are welcome to PR again. |
Adaway only needs the following permissions to work properly: DAC_OVERRIDE, SYS_PTRACE.
Note: systemless hosts kernelsu module needs to be installed, to add support.
This PR only addresses the minimal permission requirements of Adaway to let it modify hosts file.