Fixes and improvements to dev containers #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Ubuntu-20 and Ubuntu-22 containers to set the user's password to 'tianocore' and add them to the sudo group so they can run commands as root. Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Fix typo of 'intended' in the Dockerfiles. Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
nasm and acpica-tools are needed to build most EDK2 firmware, so install them in the Ubuntu-20 and Ubuntu-22 containers. Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Since the exit codes of most commands aren't checked, add "set -e" to the entrypoint scripts to make it fail if any commands exit with a non-zero code. Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
As with the Ubuntu containers, add an entrypoint script that sets up a user which matches that which is being used to run the container. However, if EDK2_DOCKER_USER_HOME hasn't been set, just run the container as root instead of failing. Add the user to the 'wheel' group and set the password to 'tianocore' to allow them to run commands as root via sudo. Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
makubacki
approved these changes
Mar 28, 2023
osteffenrh
approved these changes
Mar 29, 2023
cfernald
approved these changes
Mar 29, 2023
|
Could someone merge this please? |
|
@bcran A bit belated, but thanks for these updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed some issues when I tried using the containers, so I've made the following changes:
Issue #64, #65, #66, #67, #68
Containers Affected
Fedora-35
Fedora-37
Ubuntu-20
Ubuntu-22