EdkRepo: Process Refs By Priority Order in List-Repos and Combo #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsun49
requested changes
Sep 25, 2023
| ui_functions.print_info_msg(" {} : {}".format(source.root.ljust(length), source.commit), header=False) | ||
| elif source.tag: | ||
| elif source.tag and not source.commit: |
There was a problem hiding this comment.
I think the second part of all of these elif conditions are redundant...
not source.commitis implied already if we didn't pass intoif source.commit- Similarly,
not (source.commit or source.tag)is implied if we didn't pass intoif source.commitandelif source.tag
There was a problem hiding this comment.
Agreed that it appears redundant.
However I felt this was a better way of documenting the priority order than adding a comment while also making the logic future proof if another conditional case were added.
kevinsun49
approved these changes
Sep 25, 2023
In the List-Repos command a combo referencing a combination of tag, sha, and branch would only have the branch listed. Update if / elif block to ensure that all ref types are listed In the combo commmand a combo containing a combination of tag, sha and branch would only show the branch. Update the conditionals such that the printed ref follows EdkRepo's priority order of ref usage (SHA > Tag > Branch) Fixes tianocore#182 Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com> Reviewed-by: Kevin Sun <kevin.sun@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the List-Repos command a combo referencing a combination of tag, sha, and branch would only have the branch listed. Update if / elif block to ensure that all ref types are listed
In the combo commmand a combo containing a combination of tag, sha and branch would only show the branch. Update the conditionals such that the printed ref follows EdkRepo's priority order of ref usage (SHA > Tag > Branch)
Fixes #182