Edkrepo: Added support for listing PatchSet in repo source #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashedesimone
requested changes
Jul 22, 2022
| @@ -26,7 +26,7 @@ | |||
| RepoHook = namedtuple('RepoHook', ['source', 'dest_path', 'dest_file', 'remote_url']) | |||
| Combination = namedtuple('Combination', ['name', 'description']) | |||
| RepoSource = namedtuple('RepoSource', ['root', 'remote_name', 'remote_url', 'branch', 'commit', 'sparse', | |||
| 'enable_submodule', 'tag']) | |||
| 'enable_submodule', 'tag', 'patchSet']) | |||
There was a problem hiding this comment.
To keep with the precedent set in this file please change patchSet to patch_set
| @@ -48,6 +48,7 @@ | |||
| COMB_INVALIDINPUT_ERROR = "Invalid input: {} not found in 'combinations' property" | |||
| COMB_UNKOWN_ERROR = "Could not find a Combination named '{}' in '{}'" | |||
| ATTRIBUTE_MISSING_ERROR = "Missing required attribute. Must specify either 'branch' or 'commit' for each <Source>." | |||
| INVALID_ATTRIBUTE_ERROR = "Can not specify branch or commit or tag along with patchSet" | |||
There was a problem hiding this comment.
The name of this error string is a little two generic can we change it to INVALID_COMBO_DEFINITION_ERROR
| try: | ||
| self.patchSet = element.attrib['patchSet'] | ||
| except Exception: | ||
| self.patchSet = None |
There was a problem hiding this comment.
To keep with the style precedent set elsewhere in this file please change self.patchSet to self.patch_set
| # except (TypeError, ValueError): | ||
| # print('{} is an invalid Index.xml file or an invalid xml file.'.format(args.InputFile)) | ||
| # if args.verbose: | ||
| # traceback.print_exc() |
There was a problem hiding this comment.
Please uncomment this code. This looks like it was done while testing.
-Added support of listing a PatchSet in the section of Combinations and return the name of the patch set in the repo source tuple -Added PatchSet parameter in the RepoSource tuple -Added mutual exclusivity among branch/commit/tag and pacthSets Signed-off-by: Harsh Vora <harsh.vora@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #74
Signed-off-by: Harsh Vora harsh.vora@intel.com