Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppPkg: Fix various typos #1

Closed
wants to merge 1 commit into from
Closed

Conversation

Coeur
Copy link

@Coeur Coeur commented Jun 27, 2019

Meta

This is an experimental pull request, as discussed many times on the edk2 mailing-list.
It is:

  • an easy pull request
  • a non-urgent pull request

It fits the experiment of using a GitHub pull request over a mailing-list patch.

Once reviewed and approved, the maintainer of this repo (edk2-libc) has multiple possibilities to handle it:

  • either use command line to rebase/merge/etc. this pull request (git pull https://github.com/coeur/edk2-libc.git Typo-AppPkg)
  • either use the GitHub interface and choose to rebase (or merge or squash): Screen Shot 2019-06-27 at 12 24 32 PM

Pull Request

This is actually a cherry pick of a larger change updated since 2018 at Coeur/edk2@1ee272d.

Fix various typos in AppPkg.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Coeur <coeur@gmx.fr>
@jpshivakavi
Copy link
Contributor

Recommend you to send a patch review request by rebasing to latest edk2-libc code base. The patch request needs to be sent to devel@edk2.groups.io
You may follow the code contribution instructions provided in https://github.com/tianocore/edk2/blob/master/ReadMe.rst

@Coeur
Copy link
Author

Coeur commented Apr 1, 2023

Not interested in doing patch files anymore. I only do PR.

@Coeur Coeur closed this Apr 1, 2023
@bcran
Copy link
Member

bcran commented Apr 1, 2023

Would you mind if I re-open this and submit the patch to the mailing list myself?
I'd really like the project to stop throwing good contributions away because we're still using outdated practices like requiring people email patches to the mailing list.

@Coeur Coeur reopened this Apr 2, 2023
@Coeur
Copy link
Author

Coeur commented Apr 2, 2023

Sure. go ahead

@jpshivakavi
Copy link
Contributor

@Coeur Could you please add the signed off by tag in the comments section in this format

Signed-off-by:

Post this I will be able to submit email patch to devel@edk2.groups.io

@jpshivakavi
Copy link
Contributor

@Coeur
Could you please add the signed off by tag in the comments section in this format
Signed-off-by: Name

@Coeur
Copy link
Author

Coeur commented Oct 31, 2023

There are no intellectual property at doing spelling corrections.
Feel free to re-appropriate those fixes.
But edk2 process is too archaic for younger generations: I did a PR to encourage PR review and PR merge, not email patches.

@Coeur Coeur closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants