Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to StdLib #3

Closed
wants to merge 3 commits into from
Closed

Additions to StdLib #3

wants to merge 3 commits into from

Conversation

vonericsen
Copy link

I made a few changes to edk2 stdlib to build an application for the UEFI shell.

  • Added format macros for int types to Aarch64, ARM, and Ia32. Also modified the X64 macros so that everything would build when they are used.
  • Added some macros that can be used for compatibility that define when socklen_t has been defined.
  • Added getopt_long parser from OpenBSD to provide long and short option parsing capability with getopt.

Tyler Erickson added 3 commits August 19, 2019 16:30
Updating macros for X64 to work with EDKII compile.

Signed-off-by: Tyler Erickson tyler.j.erickson@seagate.com
…en socklen_t is defined.

Signed-off-by: Tyler Erickson tyler.j.erickson@seagate.com
…ng and short option parsing and replaces the previous implementation that was in EDKII.

Signed-off-by: Tyler Erickson tyler.j.erickson@seagate.com
@jpshivakavi
Copy link
Contributor

If you are still interested in contributing this change to edk2-libc. Recommend you to send a patch review request by rebasing to latest edk2-libc code base. The patch request needs to be sent to devel@edk2.groups.io
You may follow the code contribution instructions provided in https://github.com/tianocore/edk2/blob/master/ReadMe.rst

@jpshivakavi
Copy link
Contributor

@vonericsen Could you please add the signed off by tag in the comments section in this format

Signed-off-by:

Post this I will be able to submit email patch to devel@edk2.groups.io

@vonericsen
Copy link
Author

@jpshivakavi,
Sorry I did not see this earlier! For some reason the notification went to a different email box that I don't monitor as often.
You are welcome to submit this if you would like to. I think I kept hitting firewall issues years ago when I was trying.
We have not used this in a while due to no longer pursuing UEFI tools at this time and I forgot that this was still open.

Signed-off-by: Tyler Erickson tyler.erickson@seagate.com

@jpshivakavi
Copy link
Contributor

@vonericsen
Thanks for your response. I will submit the email patch on your behalf for review by the community. Hope you don't mind if I get back to you if anything else needed from you to process this PR.

@jpshivakavi
Copy link
Contributor

@vonericsen
Extracted patch from this PR and sent it as email patch to devel@edk2.groups.io.
There are couple of comments related to the changes.
I have added you to the email thread. Please check and respond accordingly.

@jpshivakavi
Copy link
Contributor

PR not meeting the Tianocore project contribution requirements and hence closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants