-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for consistent multi-pkg support in invocables. #48
Merged
spbrogan
merged 15 commits into
tianocore:master
from
spbrogan:refactor_allow_actual_settings
Sep 10, 2019
Merged
Refactor for consistent multi-pkg support in invocables. #48
spbrogan
merged 15 commits into
tianocore:master
from
spbrogan:refactor_allow_actual_settings
Sep 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed of actual settings used for critical values that could allow for SettingsManager to provide different scopes, repos, etc. This is a breaking change for Ci Build and corresponding changes will be made to other edk2_ (stuart) tools.
…i and settings manager so that optimizations can be done
This attempts to resolve issue #47 |
…not aware of settingsmanagers so the function should not be named.
This is a breaking change. |
this also resolves #31 |
Fixes #31 |
@spbrogan is there an example of a CI file that uses this? I'm trying to evaluate the flow and I'd like to see it |
matthewfcarlson
approved these changes
Sep 9, 2019
… runs without dependency on TARGET
spbrogan
changed the title
Refactor allow actual settings
Refactor for consistent multi-pkg support in invocables.
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.