Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for consistent multi-pkg support in invocables. #48

Merged
merged 15 commits into from
Sep 10, 2019

Conversation

spbrogan
Copy link
Member

@spbrogan spbrogan commented Sep 9, 2019

No description provided.

…ed of actual settings used for critical values that could allow for SettingsManager to provide different scopes, repos, etc.

This is a breaking change for Ci Build and corresponding changes will be made to other edk2_ (stuart) tools.
…i and settings manager so that optimizations can be done
@spbrogan
Copy link
Member Author

spbrogan commented Sep 9, 2019

This attempts to resolve issue #47

…not aware of settingsmanagers so the function should not be named.
@spbrogan
Copy link
Member Author

spbrogan commented Sep 9, 2019

This is a breaking change.
This has been tested on a platform build and ci builds but does require a few new functions added.

@spbrogan
Copy link
Member Author

spbrogan commented Sep 9, 2019

this also resolves #31

@matthewfcarlson
Copy link
Contributor

matthewfcarlson commented Sep 9, 2019

Fixes #31

@matthewfcarlson
Copy link
Contributor

@spbrogan is there an example of a CI file that uses this? I'm trying to evaluate the flow and I'd like to see it

edk2toolext/base_abstract_invocable.py Outdated Show resolved Hide resolved
edk2toolext/invocables/edk2_ci_build.py Show resolved Hide resolved
edk2toolext/invocables/edk2_ci_build.py Outdated Show resolved Hide resolved
edk2toolext/invocables/edk2_ci_build.py Show resolved Hide resolved
edk2toolext/invocables/edk2_setup.py Outdated Show resolved Hide resolved
edk2toolext/invocables/edk2_update.py Outdated Show resolved Hide resolved
@spbrogan spbrogan merged commit 52e153d into tianocore:master Sep 10, 2019
@spbrogan spbrogan deleted the refactor_allow_actual_settings branch September 10, 2019 19:03
@spbrogan spbrogan changed the title Refactor allow actual settings Refactor for consistent multi-pkg support in invocables. Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants