Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace variables doesn't work well when there is a space #56

Closed
matthewfcarlson opened this issue Nov 24, 2019 · 2 comments
Closed

Replace variables doesn't work well when there is a space #56

matthewfcarlson opened this issue Nov 24, 2019 · 2 comments
Assignees
@matthewfcarlson
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@matthewfcarlson
Copy link
Contributor

!if $ (SECURE_BOOT_ENABLE) == TRUE
becomes
0!if $ (SECURE_BOOT_ENABLE) == TRUE
Which means we don't resolve it as a conditional
@matthewfcarlson matthewfcarlson added the bug Something isn't working label Nov 24, 2019
@matthewfcarlson matthewfcarlson self-assigned this Jan 14, 2020
@matthewfcarlson matthewfcarlson mentioned this issue Jan 14, 2020
Closed
@matthewfcarlson matthewfcarlson added the ready shows this PR is ready to be merged label Jan 14, 2020
@matthewfcarlson
Copy link
Contributor Author

There's some talk about whether this is spec compliant and if we should even support this

@Javagedes Javagedes added invalid This doesn't seem right and removed ready shows this PR is ready to be merged labels Apr 26, 2022
@Javagedes
Copy link
Contributor

Closing due to the comments in #68. Feel free to re-open if incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfcarlson matthewfcarlson

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] Fixes spaces in variable resolution for base parser matthewfcarlson/edk2-pytool-library
2 participants
@matthewfcarlson @Javagedes