[Bug] Fixes spaces in variable resolution for base parser #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corthon
suggested changes
Jan 16, 2020
| line = "Hello $ (name)!" | ||
| self.assertEqual(parser.ReplaceVariables(line), "Hello sean!") | ||
| line = "Hello $( name )!" | ||
| self.assertEqual(parser.ReplaceVariables(line), "Hello sean!") |
There was a problem hiding this comment.
Can you add a test for the negative case? e.g. missing $
There was a problem hiding this comment.
like line = "Hello name" or line = "Hello $name"?
There was a problem hiding this comment.
First one, then the other! :)
|
Is this syntax valid according to DSC spec? Is it allowed 1 space? N spaces? |
|
@spbrogan according to the spec here, no. https://edk2-docs.gitbooks.io/edk-ii-dsc-specification/content/v/release/1.28/3_edk_ii_dsc_file_format/33_platform_dsc_definition.html but then here: https://edk2-docs.gitbooks.io/edk-ii-dsc-specification/content/v/release/1.28/appendix_b_sample_edk_ii_dsc_file.html they use $ () in a few places. I say let's go with the spec on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56