Remove reference to BaseSortLib library #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two problems with BaseSortLib reference: 1 BaseSortLib is the library instance name not the class name. 2 UefiSortLib instance from MdeModulePkg is also referenced below. Let's use only one reference to SortLib. While Redfish Client uses only quick sort for char* elements, UefiSortLib is preferred as it allows to sort DevicePath instances and wide strings. Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Nickle Wang <nicklew@nvidia.com> Cc: Igor Kulchytskyy <igork@ami.com>
ghbaccount
force-pushed
the
remove_basesortlib_reference
branch
from
59eaf26
to
677a5aa
Compare
|
Since edk2 was updated, this PR needs to be rerun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems with BaseSortLib reference: 1 BaseSortLib is the library instance name not the class name. 2 UefiSortLib instance from MdeModulePkg is also referenced below.
Let's use only one reference to SortLib.
While Redfish Client uses only quick sort for char* elements, UefiSortLib is preferred as it allows to sort DevicePath instances and wide strings.
Signed-off-by: Mike Maslenkin mike.maslenkin@gmail.com
Cc: Abner Chang abner.chang@amd.com
Cc: Nickle Wang nicklew@nvidia.com
Cc: Igor Kulchytskyy igork@ami.com