Skip to content

Commit

Permalink
MdeModulePkg/Usb: Read a large number of blocks
Browse files Browse the repository at this point in the history
Changes to allow reading blocks that greater than 65535 sectors.

Signed-off-by: Jiangang He <jiangang.he@amd.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Kuei-Hung Lin <Kuei-Hung.Lin@amd.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
  • Loading branch information
changab authored and mergify[bot] committed Jan 16, 2023
1 parent 8147fe0 commit be8d6ef
Showing 1 changed file with 12 additions and 13 deletions.
25 changes: 12 additions & 13 deletions MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Pei USB ATAPI command implementations.
Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
Expand Down Expand Up @@ -382,14 +383,14 @@ PeiUsbRead10 (
ATAPI_PACKET_COMMAND Packet;
ATAPI_READ10_CMD *Read10Packet;
UINT16 MaxBlock;
UINT16 BlocksRemaining;
UINT16 SectorCount;
UINT32 BlocksRemaining;
UINT32 SectorCount;
UINT32 Lba32;
UINT32 BlockSize;
UINT32 ByteCount;
VOID *PtrBuffer;
EFI_STATUS Status;
UINT16 TimeOut;
UINT32 TimeOut;

//
// prepare command packet for the Inquiry Packet Command.
Expand All @@ -401,16 +402,13 @@ PeiUsbRead10 (

BlockSize = (UINT32)PeiBotDevice->Media.BlockSize;

MaxBlock = (UINT16)(65535 / BlockSize);
BlocksRemaining = (UINT16)NumberOfBlocks;
MaxBlock = (UINT16)(MAX_UINT16 / BlockSize);
ASSERT (NumberOfBlocks < MAX_UINT32);
BlocksRemaining = (UINT32)NumberOfBlocks;

Status = EFI_SUCCESS;
while (BlocksRemaining > 0) {
if (BlocksRemaining <= MaxBlock) {
SectorCount = BlocksRemaining;
} else {
SectorCount = MaxBlock;
}
SectorCount = MIN (BlocksRemaining, MaxBlock);

//
// fill the Packet data structure
Expand All @@ -435,7 +433,7 @@ PeiUsbRead10 (

ByteCount = SectorCount * BlockSize;

TimeOut = (UINT16)(SectorCount * 2000);
TimeOut = SectorCount * 2000;

//
// send command packet
Expand All @@ -448,16 +446,17 @@ PeiUsbRead10 (
(VOID *)PtrBuffer,
ByteCount,
EfiUsbDataIn,
TimeOut
(UINT16)MIN (TimeOut, MAX_UINT16)
);

if (Status != EFI_SUCCESS) {
return Status;
}

ASSERT (Lba32 <= (MAX_UINT32-SectorCount));
Lba32 += SectorCount;
PtrBuffer = (UINT8 *)PtrBuffer + SectorCount * BlockSize;
BlocksRemaining = (UINT16)(BlocksRemaining - SectorCount);
BlocksRemaining = BlocksRemaining - SectorCount;
}

return Status;
Expand Down

0 comments on commit be8d6ef

Please sign in to comment.