ArmPkg: Fix various typos #143
Conversation
Fix various typos in ArmPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur <coeur@gmx.fr>
|
Antoine, I'll have to reject this github PR (similarly to other github pull requests for the edk2 project). While we may have discussed github pull requests for other projects on the list, such as "Edk2-Library", to my knowledge we're not even considering an evaluation of github pull requests for the main edk2 project. Please submit your patch to the list for review. The point is exactly that patch review happen on the list. Thanks. |
|
For the record, a few months ago we did evaluate github, phabricator, and gitlab. Gerrit was added to the "evaluation backlog". From the three we checked, at that time, github proved the least inferior to the mailing list. We identified a number of sticking points which github.com should address before we could consider adopting it. http://mid.mail-archive.com/793375cd-f55a-fa22-97c2-d6fd04da7d8b@linux.intel.com (Alternative links: https://lists.01.org/pipermail/edk2-devel/2019-February/036428.html Nothing has changed since, to my knowledge, so I don't see a reason to reopen the investigation. |
|
:( |
…ianocore#143) ## Description The variable used to check if we added entries to the memory map should be MemoryMapEnd, not MapEntryEnd. ## Breaking change? No ## How This Was Tested Testing special regions ## Integration Instructions N/A
Meta
This is an experimental pull request, as discussed many times on the edk2 mailing-list.
It is:
It fits the experiment of using a GitHub pull request over a mailing-list patch.
Once reviewed and approved, the maintainer of this repo (edk2) has multiple possibilities to handle it:
git pull https://github.com/coeur/edk2.git Typo-ArmPkg)Pull Request
This is actually a cherry pick for ArmPkg only from a larger change updated since 2018 at Coeur@1ee272d.