Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
4 times, most recently
from
9bf3939
to
4e6779b
Compare
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
2 times, most recently
from
db6676a
to
793abb1
Compare
Sean-StarLabs
changed the title
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
2 times, most recently
from
08ee533
to
5f264e2
Compare
Recent model Chromebooks only return ACK, but not BAT_SUCCESS, which causes hanging and failed ps2k init. To mitigate this, make the absence of BAT_SUCCESS reply non-fatal, and reduce the no-reply timeout from 4s to 1s. Tested on google/dracia and purism/librem_14 Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
from
5f264e2
to
33b9f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent model Chromebooks only return ACK, but not
BAT_SUCCESS, which causes hanging and failed ps2k init.
To mitigate this, make the absence of BAT_SUCCESS reply
non-fatal, and reduce the no-reply timeout from 4s to 1s.
Tested on google/dracia and purism/librem_14
Cc: Hao A Wu hao.a.wu@intel.com
Cc: Ray Ni ray.ni@intel.com
Signed-off-by: Matt DeVillier matt.devillier@gmail.com
Signed-off-by: Sean Rhodes sean@starlabs.systems