Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
from
0c2d383
to
ec6b038
Compare
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
from
ec6b038
to
c4719f5
Compare
Recent model Chromebooks only return ACK, but not BAT_SUCCESS, which causes hanging and failed ps2k init. To mitigate this, make the absence of BAT_SUCCESS reply non-fatal, and reduce the no-reply timeout from 4s to 1s. Tested on google/dracia and purism/librem_14 Acked-by: Hao A Wu <hao.a.wu@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Signed-off-by: Sean Rhodes <sean@starlabs.systems> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Sean-StarLabs
force-pushed
the
coreboot/17/keyboard_protocol
branch
from
c4719f5
to
1e49e0d
Compare
|
Thank you :)
…On Tue, 25 Oct 2022 at 08:58, Ray Ni ***@***.***> wrote:
Merged #3389 <#3389> into master.
—
Reply to this email directly, view it on GitHub
<#3389 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCKQRHPJ4FU46WVXFIDOKTWE6HK5ANCNFSM6AAAAAAQTXXGEQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent model Chromebooks only return ACK, but not
BAT_SUCCESS, which causes hanging and failed ps2k init. To mitigate this, make the absence of BAT_SUCCESS reply non-fatal, and reduce the no-reply timeout from 4s to 1s.
Tested on google/dracia and purism/librem_14
Cc: Hao A Wu hao.a.wu@intel.com
Cc: Ray Ni <ray.ni@intel.com
Signed-off-by: Sean Rhodes sean@starlabs.systems
Signed-off-by: Matt DeVillier matt.devillier@gmail.com