Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.devcontainer/devcontainer.json: Add devcontainer file #4015

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Feb 8, 2023

Tianocore maintains container images in the tianocore/containers repo
and stores container images within the GitHub container registry.

https://github.com/tianocore/containers

This change adds a devcontainer.json file to the edk2 repo. This
file's metadata and settings to configurate a development container
for a given well-defined tool and runtime stack.

More information about the devcontainer.json file is available here:
https://containers.dev/implementors/json_reference/

This file is recognized by popular tools such as GitHub Codespaces
and VS Code. In VS Code in particular, it makes it much easier for
a user to be aware a dev container exists (via UI notifications)
and to load the container.

A minimal number of VS Code extensions are specified that are useful
for edk2 development or to assist in complying with CI checks in
place in edk2.

Cc: Andrew Fish afish@apple.com
Cc: Chris Fernald chris.fernald@outlook.com
Cc: Leif Lindholm quic_llindhol@quicinc.com
Cc: Michael D Kinney michael.d.kinney@intel.com
Cc: Oliver Steffen osteffen@redhat.com
Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com
Reviewed-by: Michael D Kinney michael.d.kinney@intel.com

@makubacki
Copy link
Member Author

@lgao4 - as requested to merge into stable tag

@mdkinney mdkinney added push Auto push patch series in PR if all checks pass and removed push Auto push patch series in PR if all checks pass labels Feb 14, 2023
@mdkinney
Copy link
Member

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Feb 14, 2023

rebase

❌ Base branch update has failed

Git reported the following error:

Pushing to https://github.com/makubacki/edk2
POST git-receive-pack (1587 bytes)
remote: error: GH006: Protected branch update failed for refs/heads/add_devcontainer_json.        
remote: error: At least 1 approving review is required by reviewers with write access. Cannot force-push to this branch        
To https://github.com/makubacki/edk2
 ! [remote rejected]     add_devcontainer_json -> add_devcontainer_json (protected branch hook declined)
error: failed to push some refs to 'https://github.com/makubacki/edk2'

err-code: CBBF2

Tianocore maintains container images in the tianocore/containers repo
and stores container images within the GitHub container registry.

https://github.com/tianocore/containers

This change adds a devcontainer.json file to the edk2 repo. This
file's metadata and settings to configurate a development container
for a given well-defined tool and runtime stack.

More information about the devcontainer.json file is available here:
https://containers.dev/implementors/json_reference/

This file is recognized by popular tools such as GitHub Codespaces
and VS Code. In VS Code in particular, it makes it much easier for
a user to be aware a dev container exists (via UI notifications)
and to load the container.

A minimal number of VS Code extensions are specified that are useful
for edk2 development or to assist in complying with CI checks in
place in edk2.

Cc: Andrew Fish <afish@apple.com>
Cc: Chris Fernald <chris.fernald@outlook.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Feb 14, 2023
@mergify mergify bot merged commit 540522f into tianocore:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants