BaseTools/Scripts/PatchCheck.py: Check for *.makefile #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for Makefiles, also check for *.makefile: this allows
{header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be
detected and avoid having PatchCheck.py complain about tab characters.
Also, change the check for "Makefile" to be case-insensitive since there
are some Makefiles named 'makefile' instead of 'Makefile'.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
bcran
force-pushed
the
patchcheck_makefiles
branch
from
f409b33
to
6548cda
Compare
|
PR can not be merged due to conflict. Please rebase and resubmit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for Makefiles, in addition to Makefile and GNUmakefile, also check for *.makefile: this allows {header,footer,app,lib}.makefile in BaseTools/Source/C/Makefiles to be detected and avoid having PatchCheck.py complain about tab characters.