Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clangdwarf #4240

Merged
merged 14 commits into from
May 5, 2023
Merged

Clangdwarf #4240

merged 14 commits into from
May 5, 2023

Conversation

bcran
Copy link
Member

@bcran bcran commented Apr 5, 2023

No description provided.

@mergify
Copy link

mergify bot commented Apr 5, 2023

PR can not be merged due to conflict. Please rebase and resubmit

@bcran bcran force-pushed the clangdwarf branch 8 times, most recently from 9ffbec2 to 05e697f Compare April 19, 2023 18:34
@gguo11837463
Copy link
Contributor

gguo11837463 commented Apr 20, 2023 •
edited

I still encounter CLANG_DWARF build failure on my local Windows build machine after this PR

Currently, UefiPayloadPkg will need to depend on CLANGDWARF compiler on windows and linux, I don't want to see it failure. This commit can unlock my side build fail for you to refer.
gguo11837463@615c823

Currently, https://github.com/tianocore/edk2/blob/master/edksetup.bat auto detect CLANG_BIN, and CLANG_BIN support both CLANGDWARF or CLANGPDB. And on Windows objcopy is not provide by pure clang compiler. So change it from llvm-objcopy to objcopy will make some Windows user build failure after the PR submitting.

If some package encounter maybe they can use *.dsc -> to switch it from llvm-objcopy to objcopy. Default llvm-objcopy should be make sense for clang compiler due to it provide for llvm organization.

image

@bcran
Copy link
Member Author

bcran commented Apr 20, 2023

Default llvm-objcopy should be make sense for clang compiler due to it provide for llvm organization.

Thanks for testing this. I've got a Windows setup now and I'm working on fixing it.
Changing it to llvm-objcopy isn't quite so simple because it seems OBJCOPY_PATH isn't used, so it tries to run "llvm-objcopy" instead of C:\llvm\bin\llvm-objcopy. I'll need to fix the python script that generates the makefiles.

@bcran bcran force-pushed the clangdwarf branch 4 times, most recently from 4a7522f to 7968c0c Compare April 25, 2023 14:22
@bcran bcran force-pushed the clangdwarf branch 6 times, most recently from da2dd8d to 5c4e2f1 Compare May 1, 2023 21:12
bcran added 9 commits May 5, 2023 04:32
@bcran
BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions
9334545 
With recent changes, Visual Studio versions older than VS2015 are
unable to build EDK2 code.

To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain
definitions from Conf/tools_def.template, leaving only versions that can
be used to successfully build firmware.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Remove VS2008-VS2013 remnants
fcf0ba5 
Remove remnants of Visual Studio 2008-2013 support from
Conf/tools_def.txt and various batch scripts.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
MdePkg: Remove VS2008-VS2013 remnants
611a50b 
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from MdePkg.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
edksetup.bat: Remove VS2008-VS2013 remnants
86f35a7 
Since Visual Studio versions older than VS2015 are no longer supported,
remove mention of them from edksetup.bat.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs
d03bcde 
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions
from Conf/tools_def.template.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Remove EBC (EFI Byte Code) compiler definitions
5f9ab87 
The edk2-stable202302 release was the last to support building
EFI Byte Code drivers. Since the Intel EFI Byte Code Compiler is no
longer available, a decision has been made to remove support for EBC
from edk2.

Remove the definitions for Intel's EBC compiler from
Conf/tools_def.template.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Update VS toolchain descriptions in tools_def.txt.template
b0956e5 
Update the Visual Studio toolchain descriptions in
tools_def.txt.template:

- The WinDDK is no longer needed.
- Update 3 is required for VS 2015.
- VS 2005 has been removed.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
Add GCC and GCCNOLTO toolchains to tools_def.txt and update packages
4be50e3 
Add a 'GCC' toolchain that's a copy of the existing GCC5 definition.
Add a 'GCCNOLTO' toolchain that's a copy of the existing GCC49
toolchain.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools/Conf/tools_def.template: Add section for deprecated toolchains
f9238dd 
In order to make it clear for anyone reading tools_def.template, add
a section for deprecated tool chains and move GCC48, GCC49 and GCC5
into it.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
bcran added 5 commits May 5, 2023 04:40
@bcran
BaseTools: Add ARM and AARCH64 CLANGDWARF support in tools_def.template
70876c3 
Add ARM and AARCH64 support to CLANGDWARF in tools_def.template, copying
the CLANG38 definitions.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: As with CLANGDWARF IA32 and X64, use lld for ARM and AARCH64
5807861 
As with the IA32 and X64 CLANGDWARF toolchain definitions, use ld.lld
for ARM and AARCH64.

Add -Wl,--no-pie,--no-relax to the command line to fix linking when
using lld.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Remove CLANG35 toolchain from tools_def.template
9b2c5fb 
Clang 3.5 is a very old release and is no longer relevant. Remove the
CLANG35 toolchain from tools_def.template.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools: Delete CLANG38 from tools_def.template
b63c903 
Clang 3.8 is a very old release and is no longer relevant. Delete the
CLANG38 toolchain from tools_def.template.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran
BaseTools/Conf/tools_def.template: Bump VERSION to 3.00
28c6af7 
Bump VERSION to 3.00 and explain the changes made to the toolchains.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
@bcran bcran added the push Auto push patch series in PR if all checks pass label May 5, 2023
@mergify mergify bot merged commit 757f502 into tianocore:master May 5, 2023
124 checks passed
@bcran bcran deleted the clangdwarf branch May 5, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcran @gguo11837463