Fixes for SEV-SNP CC blob and CPUID table handling #4313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: Michael Roth michael.roth@amd.com
Date: 4/26/2023 4:32:54 AM
Subject: [PATCH v2 0/4] Fixes for SEV-SNP CC blob and CPUID table handling
(Mainly a resend of v1, but rolled in Gerd's Acked-by's, addressed
new coding style check in the CI, and updated Cc list)
Here are a number of fixes related to OVMF handling of the SEV-SNP
Confidential Computing blob and CPUID table.
Patch #1 is a fix for recently-reported issue that can cause
significant problems with some SEV-SNP guest operating systems.
Please consider applying this patch directly if the other
patches in this series are held up for any reason.
Patches 2-4 are minor changes for things that aren't currently
triggered in practice, but make OVMF's SEV-SNP implementation more
robust for different build/hypervisor environments in the future.
Patch #2 was submitted previously, but refreshed here to apply
cleanly on top of Patch #1, with no other functional changes since
the initial review.
v2:
test cases
Michael Roth (4):
OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory
OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition
OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation
OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP
OvmfPkg/AmdSevDxe/AmdSevDxe.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------
OvmfPkg/Include/Guid/ConfidentialComputingSevSnpBlob.h | 6 ++++--
OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 13 +++++--------
3 files changed, 59 insertions(+), 24 deletions(-)