Bug xxx tpm cplusplus resevered keywords #4436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdkinney
force-pushed
the
Bug_xxx_TpmCplusplusReseveredKeywords
branch
3 times, most recently
from
6936f6f
to
d57e1b6
Compare
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. This patch temporarily introduces an anonymous union to add Operator and Xor fields to support migration from the current field names to the new field names. Warning 4201 is disabled for VS20xx tool chains is a temporary change to allow the use of anonymous unions. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Oliver Smith-Denny <osde@linux.microsoft.com> Cc: Pedro Falcato <pedro.falcato@gmail.com> Cc: Aaron Pop <aaronpop@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Change xor to Xor to avoid C++ reserved work name collisions when building with C++ compilers. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Oliver Smith-Denny <osde@linux.microsoft.com> Cc: Pedro Falcato <pedro.falcato@gmail.com> Cc: Aaron Pop <aaronpop@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. This patch removes the temporary use of anonymous unions and warning 4201 disable for VS20xx tool chains to complete the following field name changes: * operator -> Operator * xor -> Xor NOTE: This is a non-backwards compatible change to Tpm12.h and Tmp20.h. And consumers of these include files that access the "operator" or "xor" fields must be updated. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Oliver Smith-Denny <osde@linux.microsoft.com> Cc: Pedro Falcato <pedro.falcato@gmail.com> Cc: Aaron Pop <aaronpop@microsoft.com> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
mdkinney
force-pushed
the
Bug_xxx_TpmCplusplusReseveredKeywords
branch
from
d57e1b6
to
0357c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords
operator and xor in C structures to support use of these
include files when building with a C++ compiler.
NOTE: This is a non-backwards compatible change to Tpm12.h
and Tmp20.h. And consumers of these include files that access
the "operator" or "xor" fields must be updated.
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Zhiguang Liu zhiguang.liu@intel.com
Cc: Oliver Smith-Denny osde@linux.microsoft.com
Cc: Pedro Falcato pedro.falcato@gmail.com
Cc: Aaron Pop aaronpop@microsoft.com
Signed-off-by: Michael D Kinney michael.d.kinney@intel.com