Add a preinst script to fail if aufs is in use #4
Conversation
|
IMO this would be worth a Hitting |
| 3. Update to src:linux >= 4.1.1-1~exp1 ("aufs: Apply patches to enable | ||
| building aufs out-of-tree"), and then compile the aufs modules out-of-tree | ||
| (a package for doing this module compilation automatically doesn't yet | ||
| exist at the time of this writing, but might in the future). |
There was a problem hiding this comment.
Hah! Since I wrote this, aufs-dkms is now a thing -- is that going to be "supported" on Ubuntu to the same level it is on Debian, or are even the "AUFS enabling" patches being removed from src:linux* in Ubuntu?
There was a problem hiding this comment.
(If not, it may be worth calling that out in the above NEWS entry, but if so then it's probably fine to just leave as-is and make users actually dig if they want to stay on AUFS for some reason I cannot fathom.)
There was a problem hiding this comment.
Having done some more digging, aufs-dkms is in bad shape, and in Ubuntu is currently provided by the kernel package (and due to the basket case AUFS is, can't really be sustainable/maintainable for the wide swath of kernels Ubuntu supports), so it's probably worth making the new NEWS entry explicitly call out that option three here is not actually worth users time trying to chase down and they do need to migrate (or maintain their own kernel builds 
).
There was a problem hiding this comment.
I've updated the NEWS entry. Thanks for the feedback!
|
I believe @mwhudson is going to take a look and do the upload/merge later. Thanks for reviewing! |
The aufs storage driver is deprecated. If any containers are using aufs, we should block the upgrade of the docker package so that the users can make the necessary changes to get off of aufs.
The existence of /var/lib/docker/aufs is the best indicator for whether any containers may be using aufs. This is how docker's backend code checks the valid storage drivers, and avoids any complications of having multiple docker daemons running simultaneously.