Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute DOM events outside Angular zones #212

Closed
klemenoslaj opened this issue Jan 11, 2018 · 3 comments
Closed

Execute DOM events outside Angular zones #212

klemenoslaj opened this issue Jan 11, 2018 · 3 comments
Assignees
Milestone

Comments

@klemenoslaj
Copy link

I would strongly encourage to trigger all DOM events outside the zone in order to get additional performance out of gridster2.

I am currently implementing gridster2 into existing project, where each GridItem contains one pretty expensive component, and I can totally feel the problem.
Another scenario where this can cause problems are applications in migration from AngularJS to Angular by using ngUpgrade, since there $digest is triggered in addition.

On your demo app

Inside angular
screen shot 2018-01-11 at 14 53 47

Outside angular
screen shot 2018-01-11 at 14 52 25

@tiberiuzuld
Copy link
Owner

Ok, will do.
After I fix the bug with PushService.

@klemenoslaj
Copy link
Author

Hi @tiberiuzuld, yes, the PushService issue is more important for sure.

Thanks for the great work!

@tiberiuzuld
Copy link
Owner

Implemented in v5.0 for drag move and resize move events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants