-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS grid refactor makes item displacement look less fluid #272
Comments
Hi @mattmutt ,
Still under consideration if should I move it to css grid or not. Pros to grid:
Cons to grid:
Any suggestions are welcome Thanks |
Would it be worthwhile to explore adding additional children DIV wrappers inside the tag that holds the CSS grid cell? If the actual presented content is inside an absolutely positioned DIV, which is then wrapped by a relative positioned wrapper DIV, it is possible to separate the content from the grid cell. To deal with the transition, the flow might go like this:
Here is a representation of what I meant by making some new wrappers to help with moving the contents around ( but keeping the original grid cell position allocated until a swap must occur ). just some thoughts |
This option will complicate push a lot... |
the wrapper is just an invisible placeholder to allocate space. the red layer is displaced via a |
Yes kinda but also made improvements which where possible before but didn't see them. The library will work with both types of layouts. Will make a commit soon to try it out. |
So besides edge scrolling on Absolute grid everything else should work fine. |
So today tried to fix a lot of issue with the css grid and hit more road blocks with the transitions and animations so decided to scrap it. Removed today the css grid from master. Kept some of the improvements I made for the grid code which will be in version 5.0.0. Thanks |
Since adopting the CSS Grid, any time other grid items swap or relocate their position to make room while dragging the intended item, there is no longer a smooth animation. They just jump around around. This is somewhat unexpected compared to the smooth movements previously.
Also this CSS grid change to the project effectively breaks on IE now, if that matters for supporting this ancient browser. IE has limited support, and perhaps a older spec of the CSS grid that it conforms to. Edge is fine.
The text was updated successfully, but these errors were encountered: