Grid Drag and Resize enabled priority #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well I kind of agree that if is disabled at grid level should override the grid setting. Since this will be a breaking change in behavior will have to merge this once with the next major version of library which is when the angular new major version is released (ETA May) I hope you can live with this till then. |
|
Yes that's not an issue as I can run my own fork till then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the logic so that the grids drag and resize enabled settings are prioritised over the items. This has helped me as I am able to enable/disable editing on my grid and when enabled the items settings are taken into account. Happy for you to reject this change is you do not wish for it to be the desired behavior.