Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big gap between the reference labels and the commit title #51

Closed
filiperinaldi opened this issue Aug 13, 2018 · 2 comments
Closed

Big gap between the reference labels and the commit title #51

filiperinaldi opened this issue Aug 13, 2018 · 2 comments

Comments

@filiperinaldi
Copy link
Contributor

There is a big gap between the ref names and the text following them in the 'Rev list' view under MacOS. See screenshot:

screen shot 2018-08-13 at 14 25 46

It works fine (no gap) when running QGit in debug mode. But in this case, the fonts are very pixelated.

@mwoehlke
Copy link
Contributor

This seems to be a HighDPI issue. I've noticed it also on Linux, on a system with display scaling == 2. It's fine on a different machine that is almost the same software but not HighDPI.

(I'm virtually certain that the width to allow is being computed in actual pixels, but applied in virtual pixels.)

@filiperinaldi
Copy link
Contributor Author

filiperinaldi commented Aug 22, 2018

Yes, the problem is in ListViewDelegate::paintLog(). The screenshot does not show, but when there are multiple markers on the same commit (tags, branches, etc) then they have compounding gaps. For this, the problem is in ListViewDelegate::addTextPixmap().

I have a fix now for both issues (I just need to clean-up and put back the conditionals QT5 flags before sending a PR): filiperinaldi@c5cf6d0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants