UI: Fix marker generation on HiDPI displays #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the markers generation when using HiDPI displays. The previous implementation was mixing real pixels and device independent pixels values when calculating sizes and spacing.
|
Fixes issue #51 |
tibirna
reviewed
Aug 25, 2018
|
|
||
| QSize pixmapSize(ofs + pw, ph); | ||
| const unsigned int mark_spacing = 2; // Space between markers in pixels |
There was a problem hiding this comment.
It is highly preferable to avoid mixing functional changes and whitespace or code cleanup (like changing variable names without changing their use).
| /* | ||
| * Return the device pixel ratio | ||
| */ | ||
| const qreal ListViewDelegate::dpr(void) const { |
There was a problem hiding this comment.
This does not need to be a private method on the class. It can very well be a local function and releave a tiny bit of the burden from the compiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the markers generation when using HiDPI displays. The
previous implementation was mixing real pixels and device independent
pixels values when calculating sizes and spacing.