Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync #184

Merged
merged 52 commits into from
Nov 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
bdf336a
README - add CI badge
tiborauer Nov 8, 2021
e73a46b
tidy aamod_coreg_extended_2_epi.xml
ethanknights Nov 8, 2021
74c9256
Replace fileparts(strtok()) with a double fileparts
AljenU Oct 22, 2021
3fbc97f
Add fallback to SPM when FSL T1 template not available
AljenU Oct 22, 2021
a9aafc7
Check for trailing filesep when constructing reqpath in aa_init
AljenU Oct 25, 2021
e0a07be
Partial fix aa_batch error in 2021b, use Task.RunningDuration when av…
AljenU Oct 25, 2021
121161d
Fix validatepaths, check full chararray at once
AljenU Oct 25, 2021
d3cf58b
Small refactor validatepaths
AljenU Oct 25, 2021
8ce6512
Fix aas_checkpath allowcolon input effect
AljenU Oct 25, 2021
3245d40
add bwt toolbox to CBSU default parameterlist
ethanknights Nov 8, 2021
f793fa9
Fix capitalization of dvars and globalmean modules
AljenU Nov 9, 2021
f7dae97
TEST - diffusion BET
tiborauer Nov 9, 2021
83af91c
CI/TEST - scrubbing
Nov 9, 2021
904f1a7
CI/TEST - diffusion BET
Nov 9, 2021
29a3109
Merge pull request #263 from AljenU/bugfixes_getting_started
tiborauer Nov 9, 2021
a3196e5
Merge pull request #268 from AljenU/bugfix-aas_checkpath-allowcolon
tiborauer Nov 9, 2021
3b20064
Merge pull request #270 from AljenU/fix-validatepaths-chararray
tiborauer Nov 9, 2021
23a3d23
Merge pull request #283 from ethanknights/tidy
tiborauer Nov 9, 2021
98298dd
Merge branch '5.7.0' into resync
tiborauer Nov 9, 2021
9fc2bbd
Merge pull request #182 from automaticanalysis/resync
tiborauer Nov 9, 2021
c0315f0
Merge branch 'automaticanalysis:master' into WASHU
tiborauer Nov 9, 2021
348ac3f
FIX - CI: typo
Nov 9, 2021
12f0878
ENH - AROMA (toolbox, CI)
Nov 9, 2021
4f5dc6c
FIX - AROMA (and test)
Nov 9, 2021
a3135ef
FIX - AROMA
Nov 9, 2021
8692731
FIX - AROMA
Nov 9, 2021
8a38c16
FIX - CI: AROMA
Nov 9, 2021
cfa2471
FIX - BWT and WLS toolboxes
tiborauer Nov 9, 2021
bc86f4a
FIX - AROMA
Nov 9, 2021
9acdab8
ENH - install tools
Nov 9, 2021
5211360
FIX - CI: python
Nov 9, 2021
60281c6
FIX - CI: pip
Nov 9, 2021
eb588b8
FIX - AROMA
Nov 10, 2021
055286f
FIX - AROMA documentation
Nov 10, 2021
db65f87
Fix aa_test_inittest, allow . in path and aa_demo being first in list
AljenU Nov 10, 2021
78577e2
Whitespace, formatting, code cleanup
AljenU Nov 8, 2021
df81a2c
Fix log messages containing a path
AljenU Nov 8, 2021
f9883c5
Update aas_checkpath for windows compatibility
AljenU Nov 8, 2021
406f96b
Add is_absolute_path function, and use in aas_desc_outputs
AljenU Nov 8, 2021
514b0ab
Use getenv('HOME') instead of ~
AljenU Nov 10, 2021
073f08a
Fix aas_shell: do not try to stop colours on windows
AljenU Nov 10, 2021
1213112
Do not do aas_expandpathbyvars on windows
AljenU Nov 10, 2021
d8cf3bf
Adapt aa_init to use pathsep and filesep functions
AljenU Nov 10, 2021
e16279a
FIX - aaq SLURM/Torque with initialSubmitArguments
tiborauer Nov 11, 2021
3cd5aa9
Merge pull request #292 from tiborauer/WASHU
jones-michael-s Nov 11, 2021
aa8eddb
Merge branch '5.7.0' into resync
tiborauer Nov 11, 2021
8122989
Merge pull request #183 from automaticanalysis/resync
tiborauer Nov 11, 2021
7d23a77
FIX - update WASHU toolboxes
tiborauer Nov 11, 2021
2113682
FIX - parametersets with partial toolboxes
Nov 11, 2021
f694f71
Merge pull request #273 from tiborauer/5.7.0
jones-michael-s Nov 12, 2021
01bde66
Merge pull request #291 from AljenU/fixes_windows_helloworld
tiborauer Nov 12, 2021
2254c89
Merge branch 'master' into resync
tiborauer Nov 13, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
189 changes: 189 additions & 0 deletions .github/workflows/aa_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,83 @@ defaults:

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
aatest_ds000114_AROMA:
name: Testing AROMA on fMRI

# The type of runner that the job will run on
runs-on: ubuntu-latest

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- name: Maximize build space
uses: easimon/maximize-build-space@master
with:
root-reserve-mb: 51200
swap-size-mb: 1024
remove-dotnet: 'true'
remove-android: 'true'
remove-haskell: 'true'

- name: Set git to use LF
run: |
git config --global core.autocrlf false
git config --global core.eol lf
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
# MATLAB release to set up R2020a
release: R2020a

- name: Install tools under $HOME/tools (SPM, FaceMasking, FSL)
run: |
source $GITHUB_WORKSPACE/.github/workflows/tools_install.sh
env:
LOAD_FSL: 1
LOAD_FREESURFER: 0

- name: Retrive test data under $HOME/data/aa_demo
run: |
mkdir -p $HOME/data/aa_demo
aws s3 cp s3://openneuro.org/ds000114 $HOME/data/aa_demo/ds000114 --quiet --recursive --exclude "*" --include "task-*" --no-sign-request
aws s3 cp s3://openneuro.org/ds000114 $HOME/data/aa_demo/ds000114 --quiet --recursive --exclude "*" --include "dwi*" --no-sign-request
aws s3 cp s3://openneuro.org/ds000114/sub-01 $HOME/data/aa_demo/ds000114/sub-01 --quiet --recursive --no-sign-request
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_EC2_METADATA_DISABLED: true

- name: Configure aa
run: |
echo "Free space:"
df -h
mkdir $HOME/.aa
cp $GITHUB_WORKSPACE/.github/workflows/aap_parameters_defaults_GitHub.xml $HOME/.aa/aap_parameters_user.xml
mkdir $HOME/projects
- name: Run script
uses: matlab-actions/run-command@v1
with:
command: addpath(getenv('GITHUB_WORKSPACE')); aa_ver5; SPM = spmClass(fullfile(getenv('HOME'),'tools','spm12')); SPM.load; aa_test('glob','aatest_ds000114_AROMA','haltonerror',true)

- name: Archive results
uses: actions/upload-artifact@v2
with:
name: aatest_ds000114_AROMA
path: |
~/projects/
aatest_ds000114_dartel:
name: Testing SPM DARTEL

Expand All @@ -45,6 +122,14 @@ jobs:
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
Expand Down Expand Up @@ -114,6 +199,14 @@ jobs:
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
Expand Down Expand Up @@ -183,6 +276,14 @@ jobs:
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
Expand Down Expand Up @@ -229,6 +330,86 @@ jobs:
path: |
~/projects/
aatest_ds000114_scrubbing:
name: Testing fMRI frame censoring

# The type of runner that the job will run on
runs-on: ubuntu-latest

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
- name: Maximize build space
uses: easimon/maximize-build-space@master
with:
root-reserve-mb: 51200
swap-size-mb: 1024
remove-dotnet: 'true'
remove-android: 'true'
remove-haskell: 'true'

- name: Set git to use LF
run: |
git config --global core.autocrlf false
git config --global core.eol lf
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
# MATLAB release to set up R2020a
release: R2020a

- name: Install tools under $HOME/tools (SPM, FaceMasking, FSL standards)
run: |
source $GITHUB_WORKSPACE/.github/workflows/tools_install.sh
env:
LOAD_FSL: 0
LOAD_FREESURFER: 0

- name: Retrive test data under $HOME/data/aa_demo
run: |
mkdir -p $HOME/data/aa_demo
aws s3 cp s3://openneuro.org/ds000114 $HOME/data/aa_demo/ds000114 --quiet --recursive --exclude "*" --include "task-*" --no-sign-request
aws s3 cp s3://openneuro.org/ds000114 $HOME/data/aa_demo/ds000114 --quiet --recursive --exclude "*" --include "dwi*" --no-sign-request
aws s3 cp s3://openneuro.org/ds000114/sub-01 $HOME/data/aa_demo/ds000114/sub-01 --quiet --recursive --no-sign-request
aws s3 cp s3://openneuro.org/ds000114/sub-02 $HOME/data/aa_demo/ds000114/sub-02 --quiet --recursive --no-sign-request
aws s3 cp s3://openneuro.org/ds000114/sub-03 $HOME/data/aa_demo/ds000114/sub-03 --quiet --recursive --no-sign-request
aws s3 cp s3://openneuro.org/ds000114/sub-04 $HOME/data/aa_demo/ds000114/sub-04 --quiet --recursive --no-sign-request
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_EC2_METADATA_DISABLED: true

- name: Configure aa
run: |
echo "Free space:"
df -h
mkdir $HOME/.aa
cp $GITHUB_WORKSPACE/.github/workflows/aap_parameters_defaults_GitHub.xml $HOME/.aa/aap_parameters_user.xml
mkdir $HOME/projects
- name: Run script
uses: matlab-actions/run-command@v1
with:
command: addpath(getenv('GITHUB_WORKSPACE')); aa_ver5; SPM = spmClass(fullfile(getenv('HOME'),'tools','spm12')); SPM.load; aa_test('glob','aatest_ds000114_scrubbing','haltonerror',true)

- name: Archive results
uses: actions/upload-artifact@v2
with:
name: aatest_ds000114_scrubbing
path: |
~/projects/
aatest_ds002737_deface:
name: Testing (Freesurfer) Deface and FaceMasking

Expand All @@ -254,6 +435,14 @@ jobs:
- name: Check out repository under $GITHUB_WORKSPACE
uses: actions/checkout@v2

- name: Set up Python 2.7
uses: actions/setup-python@v2
with:
# Semantic version range syntax or exact version of a Python version
python-version: '2.7'
# Optional - x64 or x86 architecture, defaults to x64
architecture: 'x64'

- name: Set up MATLAB
uses: matlab-actions/setup-matlab@v1
with:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/aap_parameters_defaults_GitHub.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@
<toolbox desc='Toolbox with implemented interface in extrafunctions/toolboxes' ui='custom'>
<name desc='Name corresponding to the name of the interface without the "Class" suffix' ui='text'>spm</name>
<dir ui='dir'>/home/runner/tools/spm12</dir>
</toolbox>
<toolbox desc='Toolbox with implemented interface in extrafunctions/toolboxes' ui='custom'>
<name desc='Name corresponding to the name of the interface without the "Class" suffix' ui='text'>wls</name>
<dir ui='dir'>/home/runner/tools/rwls</dir>
</toolbox>
<toolbox desc='Toolbox with implemented interface in extrafunctions/toolboxes' ui='custom'>
<name desc='Name corresponding to the name of the interface without the "Class" suffix' ui='text'>aroma</name>
<dir ui='dir'>/home/runner/tools/ICA-AROMA</dir>
</toolbox>
<linuxshell desc='Linux shell used to run linux commands' ui='text'>bash</linuxshell>
<fsldir desc='Path to fsl' ui='dir'>/home/runner/tools/fsl</fsldir>
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tools_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ TEMPLATEDIR=$TOOLDIR/templates

sudo apt-get update
sudo apt-get install libtinfo5 libtinfo6 dc libxml2-utils
curl https://bootstrap.pypa.io/pip/2.7/get-pip.py -o $TOOLDIR/get-pip.py
python $TOOLDIR/get-pip.py --force-reinstall

# All MATLAB tools MUST be installed referred by the parameterset
source $GITHUB_WORKSPACE/.github/workflows/tools_urls.sh
source $GITHUB_WORKSPACE/aa_tools/toolboxes/installation_scripts/install_matlabtools.sh $GITHUB_WORKSPACE/.github/workflows/aap_parameters_defaults_GitHub.xml $TOOLDIR
source $GITHUB_WORKSPACE/aa_tools/toolboxes/installation_scripts/install_tools.sh $GITHUB_WORKSPACE/.github/workflows/aap_parameters_defaults_GitHub.xml $TOOLDIR

echo "FSL: ${LOAD_FSL}; FREESURFER: ${LOAD_FREESURFER}"

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tools_urls.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Set of variables (URL_<tool name with lower case>) describing the source of tools

URL_spm=git+https://github.com/spm/spm12
URL_facemasking=git+https://github.com/mmilch01/mask_face
URL_facemasking=git+https://github.com/mmilch01/mask_face
URL_aroma=git+https://github.com/maartenmennes/ICA-AROMA
URL_wls=git+https://github.com/jdiedrichsen/rwls
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ for supporting research at the MRC Cognition and Brain Science Unit. It
is made available to the academic community in the hope that it may
prove useful.

![CI](https://github.com/automaticanalysis/automaticanalysis/actions/workflows/aa_test.yml/badge.svg?event=push)
[![Docker image available!](https://img.shields.io/badge/docker-bids%2Faa-brightgreen.svg?logo=docker&style=flat)](https://hub.docker.com/r/bids/aa/)
[![manuscript](https://img.shields.io/badge/doi-10.3389%2Ffninf.2014.00090-blue.svg?style=flat)](http://doi.org/10.3389/fninf.2014.00090)
[![resource](https://img.shields.io/badge/RRID-SCR__003560-blue?style=flat)](https://scicrunch.org/scicrunch/Resources/record/nlx_144509-1/SCR_003560/resolver)
Expand Down