Skip to content

Commit

Permalink
swarmkit expects network-id for as target
Browse files Browse the repository at this point in the history
For any operation that involves netwoks (other than network create),
swarmkit expects the target as network-id. Service upate was using
network-name as the target and that caused the issue.

Signed-off-by: Madhu Venugopal <madhu@docker.com>
  • Loading branch information
mavenugo committed Jul 9, 2016
1 parent ad969f1 commit b32cfb3
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions daemon/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,13 @@ func (c *Cluster) UpdateService(serviceID string, version uint64, spec types.Ser
return c.errNoManager()
}

ctx := c.getRequestContext()

err := populateNetworkID(ctx, c.client, &spec)
if err != nil {
return err
}

serviceSpec, err := convert.ServiceSpecToGRPC(spec)
if err != nil {
return err
Expand Down

0 comments on commit b32cfb3

Please sign in to comment.