New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuck the Twitter Rate Limit #45

Open

b3yond opened this issue Oct 6, 2018 · 5 comments

Member

b3yond commented Oct 6, 2018

Right now, different modules use Twitter Rate Limiting:

twitterbot.py
twitterDM.py

the twitter rate limit counter is a global var in tfglobals. Each bot checks if there is space for the next request, when it's their turn. This could lead to one of the bots being skipped all the time.

Can someone think of a better solution?

b3yond added a commit that referenced this issue


          globals are in a separate python file now #39 #45

5119c6b

Member Author

b3yond commented Oct 7, 2018

We need to revert #39, this shit is unbearable.

Member Author

b3yond commented Oct 7, 2018

ah, according to https://blog.twitter.com/official/en_us/a/2008/what-does-rate-limit-exceeded-mean-updated.html the rate limit applies per account, not per app. #39 was very stupid.

b3yond changed the title ~~Twitter Rate Limiting is a lottery~~ Fuck the Twitter Rate Limit

Member Author

b3yond commented Oct 7, 2018

Let's discuss all the twitter rate limit stuff in this issue.

b3yond mentioned this issue

Rate limit 39 #49

Merged

Member Author

b3yond commented Oct 7, 2018 •

edited

on production, I put a counter into twitterDMs, which should log each request, directly after checking the rate limit. there was not one request. this shit is still broken. twitter DMs don't work because of this.

b3yond added a commit that referenced this issue


          crawl the username only once from twitter and save to db #45

9836ec7

b3yond added a commit that referenced this issue


          Revert "crawl the username only once from twitter and save to db #45"

b5de7cd

This reverts commit 9836ec7.

Member Author

b3yond commented Oct 11, 2018

okay, twitter DMs don't work for other reasons. (details: #39 )

So let's keep this issue open if other problems arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment