Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single exclamation mark: possibly a bug in the sequence parser #248

Closed
bwagner opened this issue Oct 25, 2017 · 3 comments
Closed

single exclamation mark: possibly a bug in the sequence parser #248

bwagner opened this issue Oct 25, 2017 · 3 comments
Labels
Mininotation Issues related to mininotation parsing and potential new features
Projects

Comments

@bwagner
Copy link
Contributor

bwagner commented Oct 25, 2017

dur "{0.05 0.05 0.4 0.05 0.4}%7"
and
dur "{0.05 ! 0.4 0.05 0.4}%7"

should produce the same result, but they don't.

http://lurk.org/r/post/4ZkzGA6oukTloNXX0IBDcs

@bgold-cosmos
Copy link
Contributor

bgold-cosmos commented Oct 26, 2017

I think @ has the same issue.
s "bd@2 cp hh"
sounds different from
s "{bd@2 cp hh}%4"

_ seems fine, though.

@yaxu yaxu added this to To do in Refactor via automation Sep 21, 2018
@yaxu yaxu moved this from To do to Not now in Refactor Oct 5, 2018
@yaxu
Copy link
Member

yaxu commented Nov 26, 2019

This still seems to be an issue, e.g. "{1 !}%2" :: Pattern Int gives "1 1 1 1"

@yaxu
Copy link
Member

yaxu commented Nov 26, 2019

Needs tackling alongside #369

I think the parser needs refactoring, with an additional datatype, TSeq for subsequences alongside TPat. Then a polyrhythm is a collection of sequences.

Euclidian rhythms should be patterns rather than sequences, as it's useful for the parameters are patternable. I'm unsure whether enumerations should be patterns or sequences. Their parameters currently are patternable. The choice is between allowing <0 .. 3> to be the same as <0 1 2 3> but <<0 2> .. <4 5>> not working, or having it be the same as <[0 1 2 3]>, and <0 2> .. <4 5> working. I think I prefer the former.

@yaxu yaxu added the Mininotation Issues related to mininotation parsing and potential new features label Nov 28, 2019
yaxu added a commit that referenced this issue Nov 28, 2019
@yaxu yaxu closed this as completed in 15b58c7 Nov 28, 2019
jamagin pushed a commit to jamagin/Tidal that referenced this issue Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mininotation Issues related to mininotation parsing and potential new features
Projects
No open projects
Refactor
  
Not now
Development

No branches or pull requests

3 participants