Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createParams / createParam / registerControl need tidying #1098

Open
yaxu opened this issue May 13, 2024 · 0 comments
Open

createParams / createParam / registerControl need tidying #1098

yaxu opened this issue May 13, 2024 · 0 comments
Labels
refactoring

Comments

@yaxu
Copy link
Member

yaxu commented May 13, 2024 •
edited
Loading

As discussed in #1093

We probably want to roughly rename createParam to registerControl and createParams to registerControls, but might want to make some API changes in the process.
yaxu pushed a commit that referenced this issue May 13, 2024
@kasparsj
OSC/SuperDirt fixes (#1093)
e268802 
* If note is a midi note, and it's sent together with octave to SuperDirt, then that will be wrong. instead we should to midinote whenever sure that it's a midi note.
* mapbank to work like tidal's drumFrom
* roomsize is size in SuperDirt
* fix tidal-sniffer
* export `registerControl` (but see #1098)
@yaxu yaxu mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaxu @felixroos