Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowcat should support arrays #87

Closed
felixroos opened this issue Apr 22, 2022 · 10 comments
Closed

slowcat should support arrays #87

felixroos opened this issue Apr 22, 2022 · 10 comments
Labels
enhancement improves an existing feature

Comments

@felixroos
Copy link
Collaborator

felixroos commented Apr 22, 2022

slowcat(0, [1, 2]) currently does not work. It would be handy if it worked analogous to "<0 [1 2]>"

@yaxu
Copy link
Member

yaxu commented Apr 22, 2022

I noticed this too earlier, fix incoming..

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

I'm a bit nervous about this though.. What if you want to make a pattern of lists, like chords? Could wrap them in pure but that would be a bit annoying

@felixroos
Copy link
Collaborator Author

wouldnt you do that with stack? the same could be said about sequence.. its also not really clear what the difference between sequence and cat is. do we need slowsequence?

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

A pattern of lists is a bit different from a pattern with events that coincide. Although they're not used in tidal the desire to have them has come up occasionally. I'm fine with this as the default behaviour though and looking for workarounds later if necessary
Yes true we should merge cat and sequence now. Probably we just drop the latter.

@felixroos
Copy link
Collaborator Author

https://tidalcycles.org/docs/patternlib/tour/concatenation/#cat in tidal cat is slowcat, while in strudel, its fastcat..

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

Hmm. Which do you prefer? I guess slowcat is nice for composing patterns together, fastcat is nice as an alternative to mininotation

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

So maybe cat should be a slowcat (concatenating cycles) and sequence should be a fastcat (sequencing events in a cycle)

@felixroos
Copy link
Collaborator Author

ok! maybe add seq as a shortcut too? we would also need to refactor cat usage in tunes.mjs

@yaxu
Copy link
Member

yaxu commented Apr 23, 2022

Yes to seq.

I'm just heading out now but just committed sequence -> fastcat and cat -> slowcat. It breaks an eval.mjs test too.

yaxu added a commit that referenced this issue Apr 23, 2022
@felixroos
Copy link
Collaborator Author

just migrated all the tunes + tutorial snippets to new cat behaviour

@felixroos felixroos added the enhancement improves an existing feature label Apr 24, 2022
@yaxu yaxu closed this as completed in 9df20fc Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants