Work on Codemirror 6 highlighting #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixroos
approved these changes
Apr 28, 2022
| @@ -118,6 +119,29 @@ function App() { | |||
| return () => window.removeEventListener('keydown', handleKeyPress); | |||
| }, [pattern, code, activateCode, cycle]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
looks good! we could also move this to a custom hook like useHighlights({pattern,view,started}) or similar, then we could reuse it in the mini repl
| // console.log('filter', f,t,value, e.value.from, e.value.to); | ||
| }, | ||
| }); | ||
| if (e.is(setHighlights)) { |
There was a problem hiding this comment.
that looks much simpler than what I fabricated :D didn't know you could just set the Decorations directly
| e.value | ||
| .flatMap((event) => event.context.locations || []) | ||
| .map(({ start, end }) => { | ||
| let from = tr.newDoc.line(start.line).from + start.column; |
There was a problem hiding this comment.
This should make offsetToPosition/ positionToOffset obsolete :)
|
related #28 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation of highlight marking that queries the pattern every frame. There are certainly some performance optimizations that could be done (plus some nuances of exactly how it should behave when the user starts/stops the pattern), but I think this is a good conceptual starting-point and an implementation that seems to perform pretty well.
Let me know if you've got any thoughts!