Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In source doc #117

Merged
merged 27 commits into from May 29, 2022
Merged

In source doc #117

merged 27 commits into from May 29, 2022

Conversation

felixroos
Copy link
Collaborator

No description provided.

@yaxu
Copy link
Member

yaxu commented May 20, 2022

Awesome stuff! Some thoughts looking through..

  • It would be really great to add percussive examples. We could have drum kit names for this (bd = bass drum, sn = snare, cp = clap etc) with default samples loaded
  • E.g. commas aren't just for chords, but polyphony in general, and especially polymeter. It'd be easier to exemplify that with drums I think
  • The descriptions are short but really clear I think, with the examples doing a lot of good work. it'll be interesting seeing how beginners find it
  • I think many will see 'API' as jargon, and kind of is the wrong term (for end-user not application programming), worth replacing it in the tutorial/mainstream docs at least
  • Maybe the jsdoc 'api docs' appendix should be separate on a different page. A beginner might happen across it and get confused. Having it visible is definitely motivating for fixing it up and writing more!
  • Having the ability to include jsdoc fragments in the mainstream docs/tutorial would be good for avoiding duplication of effort / hard to maintain copy-pasting

@felixroos
Copy link
Collaborator Author

It would be really great to add percussive examples. We could have drum kit names for this (bd = bass drum, sn = snare, cp = clap etc) with default samples loaded

Good idea. I'd say we can add a default drum kit, which is implicitly loaded (to make the examples shorter). We can then add melodic + rhythmic examples. As the default drum kit will be loaded with the page, we should only add a handful of sounds to keep the traffic low (especially for mobile).

Additionally, it would be handy if there was a quick way to load sample packs explicitly, like loadSamples(<githuburl>), but this should be a separate issue / PR.

Maybe the jsdoc 'api docs' appendix should be separate on a different page. A beginner might happen across it and get confused. Having it visible is definitely motivating for fixing it up and writing more!

Yes, it might be confusing, especially because the order is kind of random and not really didactic. There should be a separation between guide / tutorial and api docs. For now I just wanted to add them somewhere, in the future we'll probably have a proper docs site with routing. In the meantime, we could also "hide" it further by throwing it into a details tag (https://www.w3schools.com/tags/tag_details.asp).

Having the ability to include jsdoc fragments in the mainstream docs/tutorial would be good for avoiding duplication of effort / hard to maintain copy-pasting

yes this is absolutely possible right now with the custom jsdoc renderer. we could throw a <ApiDoc name="slowcat"/> inside the tutorial somewhere to render it wherever we want.

Also, I want to investigate a way to show dynamic tooltips / sidebar info inside the repl when the cursor is placed over a function that is documented.

@felixroos
Copy link
Collaborator Author

felixroos commented May 24, 2022

I have now changed the way the api docs are rendered:

Having the ability to include jsdoc fragments in the mainstream docs/tutorial would be good for avoiding duplication of effort / hard to maintain copy-pasting

this is now also possible. Although I think it can make sense at times to have some duplication as part of a guide with a "golden thread", where the choice of words is specifically tailored to the story of the guide (which shouldn't be part of jsdoc comments).

@felixroos
Copy link
Collaborator Author

sample support will be better with #121 so then we can use them in the minirepl

@felixroos
Copy link
Collaborator Author

I'll merge this for now, to clean up the webdirt branch, will open new PR when rest is added

@felixroos felixroos merged commit d132a9b into main May 29, 2022
@felixroos felixroos deleted the in-source-doc branch May 29, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants